Implement IConnectionEndPointFeature in Kestrel, HttpSys, and IIS by Copilot · Pull Request #62162 · dotnet/aspnetcore

Copilot · 2025-05-29T20:23:22Z

Implements IConnectionEndPointFeature across multiple server implementations (Kestrel, HttpSys, and IIS), refactors connection endpoint tagging into a shared utility, and extends the feature to SignalR's HttpConnectionContext.

You've read the Contributor Guide and Code of Conduct.
You've included unit or integration tests for your change, where applicable.
You've included inline docs for your change, where applicable.
There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

IConnectionEndPointFeature was previously only implemented in DefaultConnectionContext, which is primarily used in tests. This PR makes the feature available in production connections across Kestrel, HttpSys, and IIS, and consolidates endpoint tag logic into a shared utility.

Changes

TransportConnection and TransportMultiplexedConnection — Added IConnectionEndPointFeature support by updating the code generation configuration, regenerating the feature collection code, and implementing interface methods that delegate to the existing LocalEndPoint and RemoteEndPoint properties. This covers both regular TCP connections (HTTP/1.x, HTTP/2) and multiplexed QUIC connections (HTTP/3).
HttpSys (RequestContext + StandardFeatureCollection) — Added IConnectionEndPointFeature to the RequestContext partial class and StandardFeatureCollection feature lookup. The implementation constructs IPEndPoint on demand from the existing lazy-initialized IHttpConnectionFeature properties (LocalIpAddress/LocalPort and RemoteIpAddress/RemotePort).
IIS (IISHttpContext) — Added IConnectionEndPointFeature to IISHttpContext, including the full fast-path feature lookup support in Features.cs (static type field, backing field, Initialize(), FastFeatureGet, FastFeatureSet, and FastEnumerable). The implementation also delegates to the existing IHttpConnectionFeature properties.
src/Shared/ConnectionEndpointTags.cs (new shared file) — Extracted the connection endpoint tag logic from KestrelMetrics.cs into a shared internal utility using IConnectionEndPointFeature. Exposes two overloads:
- AddConnectionEndpointTags(ref TagList, IFeatureCollection) — used by SignalR
- AddConnectionEndpointTags(ref TagList, BaseConnectionContext) — used by Kestrel metrics, includes QUIC/TCP detection via MultiplexedConnectionContext
A private AddEndpointTags helper eliminates duplication between overloads. Tags follow OTel semantic conventions (server.address, server.port as int, network.type, network.transport).
KestrelMetrics.cs — Updated InitializeConnectionTags to delegate to the shared utility.
DefaultHubDispatcher.cs — Updated StartActivity to include connection endpoint tags in SignalR hub method activities.
HttpConnectionContext — Added IConnectionEndPointFeature to the implemented interfaces list and registered it in the feature collection, making endpoint info accessible through the standard feature interface for SignalR connections.
Tests:
- TransportConnectionFeatureCollectionTests.cs — Verifies IConnectionEndPointFeature is present in the feature collection and correctly returns/sets LocalEndPoint and RemoteEndPoint for both TransportConnection and TransportMultiplexedConnection.
- HubConnectionHandlerTests.Activity.cs — Verifies that SignalR hub activities include server.address, server.port, network.type, and network.transport tags when endpoint information is available. Note: server.port is stored as int per OTel conventions and must be checked via Activity.TagObjects rather than Activity.Tags.
- HttpSys/test/FunctionalTests/ConnectionEndPointFeatureTests.cs — Smoke test verifying that IConnectionEndPointFeature is available from httpContext.Features in an in-process HttpSys server and returns non-null IPEndPoint instances for both LocalEndPoint and RemoteEndPoint.
- IIS/IIS/test/IIS.Tests/ConnectionEndPointFeatureTests.cs — Smoke test verifying that IConnectionEndPointFeature is available from ctx.Features in an in-process IIS test server and returns non-null IPEndPoint instances for both LocalEndPoint and RemoteEndPoint.

Usage

var endpointFeature = connectionContext.Features.Get<IConnectionEndPointFeature>();
var localEndpoint = endpointFeature?.LocalEndPoint;
var remoteEndpoint = endpointFeature?.RemoteEndPoint;

Notes

No breaking changes; existing code using direct LocalEndPoint/RemoteEndPoint properties continues to work.
Activity.Tags only enumerates string-valued tags. Integer-valued tags such as server.port are only accessible via Activity.TagObjects.

Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

BrennanConroy · 2025-05-29T23:52:14Z

Looking good, can you add a test that verifies the feature is in the feature collection and has values?

Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Copilot · 2025-05-30T00:02:48Z

Looking good, can you add a test that verifies the feature is in the feature collection and has values?

Added comprehensive tests in TransportConnectionFeatureCollectionTests.cs that verify IConnectionEndPointFeature is available in the feature collection and properly returns/sets endpoint values. The tests follow existing patterns and validate both getting and setting LocalEndPoint and RemoteEndPoint through the feature interface. (dbd9f49)

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to my firewall allow list

BrennanConroy · 2025-06-07T02:45:06Z

Can you refactor https://github.com/dotnet/aspnetcore/blob/main/src/Servers/Kestrel/Core/src/Internal/Infrastructure/KestrelMetrics.cs#L322 to use the IConnectionEndPointFeature and put it in the src/Shared/ folder. Then update SignalR to use the shared code; see

aspnetcore/src/SignalR/server/Core/src/Internal/DefaultHubDispatcher.cs

Line 851 in 12feaab

    
           // See https://github.com/dotnet/aspnetcore/blob/027c60168383421750f01e427e4f749d0684bc02/src/Servers/Kestrel/Core/src/Internal/Infrastructure/KestrelMetrics.cs#L308

Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Copilot · 2025-06-07T02:59:07Z

Can you refactor https://github.com/dotnet/aspnetcore/blob/main/src/Servers/Kestrel/Core/src/Internal/Infrastructure/KestrelMetrics.cs#L322 to use the IConnectionEndPointFeature and put it in the sr...

Refactored the connection endpoint logic into a shared utility in src/Shared/ConnectionEndpointTags.cs that uses IConnectionEndPointFeature. Updated KestrelMetrics.cs to use the shared code and modified SignalR's DefaultHubDispatcher to include endpoint tags via the same shared utility. The SignalR server.address tag is now uncommented and working. (6c1244f)

BrennanConroy · 2025-06-09T16:34:09Z

Looks like there is a test failure:

Error: The given key 'network.type' was not present in the dictionary.
Stack Trace:
at System.Collections.Generic.Dictionary2.get_Item(TKey key) /_/src/Servers/Kestrel/test/Interop.FunctionalTests/Http3/Http3RequestTests.cs(106,0): at Interop.FunctionalTests.Http3.Http3RequestTests.<>c__DisplayClass2_0.<GET_Metrics_HttpProtocolAndTlsSet>b__1(CollectedMeasurement1 m)

Wonder if Http3 connections implement the feature collection differently

…ion for HTTP/3 Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Copilot · 2025-06-09T16:52:03Z

Looks like there is a test failure:

Error: The given key 'network.type' was not present in the dictionary.
Stack Trace:
...

Fixed the HTTP/3 test failure by adding IConnectionEndPointFeature support to TransportMultiplexedConnection. HTTP/3 connections use MultiplexedConnectionContext instead of regular TransportConnection, so the feature wasn't available. Added feature configuration, updated generated code, and improved shared utility with fallback logic. (45fbce8)

BrennanConroy · 2025-06-09T20:54:14Z

Looks like the test fix worked, thanks! Can you add a test for the SignalR part now? I imagine we might need to add the IConnectionEndPointFeature to HttpConnectionContext.

…ignalR endpoint tags test Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Copilot · 2025-06-09T21:07:12Z

Looks like the test fix worked, thanks! Can you add a test for the SignalR part now? I imagine we might need to add the IConnectionEndPointFeature to HttpConnectionContext.

Added IConnectionEndPointFeature implementation to HttpConnectionContext and a comprehensive test that verifies SignalR activities include endpoint tags. The test validates server.address, server.port, network.type, and network.transport tags are properly added to both connect and disconnect activities. (630a05c)

BrennanConroy · 2026-04-04T04:58:22Z

@copilot update the PR since it's been a while and the codebase has changed. Also double check the change to make sure it's good.

Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

…est compile errors Agent-Logs-Url: https://github.com/dotnet/aspnetcore/sessions/0a5a6edd-af5f-4fce-96d9-3d2ed8c69a2c Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Copilot · 2026-04-04T05:19:58Z

@copilot update the PR since it's been a while and the codebase has changed. Also double check the change to make sure it's good.

Updated the PR:

Merged with latest main - resolved the conflict in Kestrel.Core.csproj to include both our ConnectionEndpointTags.cs reference and the new Buffers.MemoryPool reference from main (af13f19).
Refactored ConnectionEndpointTags.cs - extracted the duplicated endpoint tag logic into a private AddEndpointTags helper, making both public overloads cleaner and easier to read.
Fixed test compile error - Activity.Tags only includes string-valued tags, so server.port (stored as int per OTel semantic conventions) must be checked via Activity.TagObjects instead of Activity.Tags. Updated the test accordingly.

BrennanConroy · 2026-04-05T04:03:20Z

@copilot undo the change to the submodule, and is it possible to implement the feature in httpsys and iis?

Agent-Logs-Url: https://github.com/dotnet/aspnetcore/sessions/63be0905-83a8-4217-b93d-63c59108c821 Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Copilot · 2026-04-05T04:23:38Z

@copilot undo the change to the submodule, and is it possible to implement the feature in httpsys and iis?

Done in 93ed79f:

Submodule reverted - restored src/submodules/googletest to d72f9c8a (main's version), undoing the accidental change from af13f19f.
HttpSys - added IConnectionEndPointFeature to RequestContext (interface declaration + implementation that constructs IPEndPoint from the existing lazy-initialized IHttpConnectionFeature properties) and to StandardFeatureCollection._featureFuncLookup.
IIS - added IConnectionEndPointFeature to IISHttpContext (interface declaration in FeatureCollection.cs, implementation using IHttpConnectionFeature properties, and full fast-path FastFeatureGet/FastFeatureSet/FastEnumerable support in Features.cs).

BrennanConroy · 2026-04-06T19:46:59Z

@copilot add a couple smoke tests for this in iis and httpsys. Looks like there might be a couple tests using IHttpConnectionFeature, so can use those for inspiration.

Agent-Logs-Url: https://github.com/dotnet/aspnetcore/sessions/6555e55e-2ba8-4ee0-8af9-2a28cdf45b12 Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Copilot · 2026-04-06T19:55:03Z

@copilot add a couple smoke tests for this in iis and httpsys. Looks like there might be a couple tests using IHttpConnectionFeature, so can use those for inspiration.

Added smoke tests in 49c4fd8:

HttpSys (src/Servers/HttpSys/test/FunctionalTests/ConnectionEndPointFeatureTests.cs): Request_ProvidesConnectionEndPointFeature — starts an in-process HttpSys server, retrieves IConnectionEndPointFeature from httpContext.Features, and asserts both LocalEndPoint and RemoteEndPoint are non-null IPEndPoint instances with non-zero ports.
IIS (src/Servers/IIS/IIS/test/IIS.Tests/ConnectionEndPointFeatureTests.cs): ProvidesLocalAndRemoteEndPoints — follows the same pattern as ConnectionIdFeatureTests, using TestServer.Create to retrieve IConnectionEndPointFeature and assert both endpoints are non-null IPEndPoint instances.

Copilot

Pull request overview

Adds production-server support for IConnectionEndPointFeature (Kestrel, HttpSys, IIS) and centralizes OTel connection endpoint tagging so SignalR and Kestrel metrics can attach consistent server.* / network.* tags.

Changes:

Implement/enable IConnectionEndPointFeature in Kestrel transport connections, HttpSys RequestContext, and IIS IISHttpContext feature collections.
Introduce shared ConnectionEndpointTags helper and wire it into Kestrel metrics + SignalR activities.
Add coverage tests across Kestrel, HttpSys, IIS, and SignalR activity tagging.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/SignalR/server/SignalR/test/Microsoft.AspNetCore.SignalR.Tests/HubConnectionHandlerTests.Activity.cs	Adds an activity-tagging test validating endpoint/network tags on hub activities.
src/SignalR/server/Core/src/Microsoft.AspNetCore.SignalR.Core.csproj	Links the new shared `ConnectionEndpointTags.cs` into SignalR Core.
src/SignalR/server/Core/src/Internal/DefaultHubDispatcher.cs	Extends `StartActivity` to add endpoint tags when a connection is available.
src/SignalR/common/Http.Connections/src/Microsoft.AspNetCore.Http.Connections.csproj	Links the new shared `ConnectionEndpointTags.cs` into Http.Connections.
src/SignalR/common/Http.Connections/src/Internal/HttpConnectionContext.cs	Registers `IConnectionEndPointFeature` on SignalR `HttpConnectionContext`.
src/Shared/ConnectionEndpointTags.cs	New shared utility to add `server.address`, `server.port`, `network.type`, `network.transport` tags.
src/Servers/Kestrel/tools/CodeGenerator/TransportMultiplexedConnectionFeatureCollection.cs	Updates codegen configuration to include `IConnectionEndPointFeature` for multiplexed connections.
src/Servers/Kestrel/tools/CodeGenerator/TransportConnectionFeatureCollection.cs	Updates codegen configuration to include `IConnectionEndPointFeature` for transport connections.
src/Servers/Kestrel/shared/TransportMultiplexedConnection.Generated.cs	Regenerated feature collection plumbing to support `IConnectionEndPointFeature`.
src/Servers/Kestrel/shared/TransportMultiplexedConnection.FeatureCollection.cs	Implements `IConnectionEndPointFeature` by delegating to `LocalEndPoint`/`RemoteEndPoint`.
src/Servers/Kestrel/shared/TransportConnection.Generated.cs	Regenerated feature collection plumbing to support `IConnectionEndPointFeature`.
src/Servers/Kestrel/shared/TransportConnection.FeatureCollection.cs	Implements `IConnectionEndPointFeature` by delegating to `LocalEndPoint`/`RemoteEndPoint`.
src/Servers/Kestrel/Core/test/TransportConnectionFeatureCollectionTests.cs	New tests validating presence and get/set behavior of `IConnectionEndPointFeature`.
src/Servers/Kestrel/Core/src/Microsoft.AspNetCore.Server.Kestrel.Core.csproj	Links the new shared `ConnectionEndpointTags.cs` into Kestrel Core.
src/Servers/Kestrel/Core/src/Internal/Infrastructure/KestrelMetrics.cs	Replaces inline endpoint-tag logic with the shared helper.
src/Servers/IIS/IIS/test/IIS.Tests/ConnectionEndPointFeatureTests.cs	Adds IIS functional smoke test for `IConnectionEndPointFeature`.
src/Servers/IIS/IIS/src/Core/IISHttpContext.Features.cs	Adds fast-path feature lookup plumbing for `IConnectionEndPointFeature`.
src/Servers/IIS/IIS/src/Core/IISHttpContext.FeatureCollection.cs	Implements `IConnectionEndPointFeature` on IIS via `IHttpConnectionFeature` values.
src/Servers/HttpSys/test/FunctionalTests/ConnectionEndPointFeatureTests.cs	Adds HttpSys functional smoke test for `IConnectionEndPointFeature`.
src/Servers/HttpSys/src/StandardFeatureCollection.cs	Registers `IConnectionEndPointFeature` in HttpSys standard feature lookup.
src/Servers/HttpSys/src/RequestProcessing/RequestContext.FeatureCollection.cs	Implements `IConnectionEndPointFeature` on `RequestContext` via `IHttpConnectionFeature` values.

Copilot · 2026-04-10T01:08:11Z

src/Servers/HttpSys/test/FunctionalTests/ConnectionEndPointFeatureTests.cs

+                var endPointFeature = httpContext.Features.Get<IConnectionEndPointFeature>();
+                localEndPoint = endPointFeature.LocalEndPoint;
+                remoteEndPoint = endPointFeature.RemoteEndPoint;
+            }
+            catch (Exception ex)
+            {
+                byte[] body = Encoding.ASCII.GetBytes(ex.ToString());
+                httpContext.Response.Body.Write(body, 0, body.Length);
+            }
+            return Task.FromResult(0);


This test uses Exception and Task (catch (Exception ex) / Task.FromResult) but the file doesn’t import System / System.Threading.Tasks (and doesn’t fully qualify those types). This will fail to compile; add the missing using directives or fully qualify the types used in the callback.

Copilot · 2026-04-10T01:08:12Z

src/Shared/ConnectionEndpointTags.cs

+        // There isn't an easy way to detect whether QUIC is the underlying transport from a feature collection alone.
+        // This code assumes that a multiplexed connection is QUIC.
+        // Improve in the future if there are additional multiplexed connection types.


The QUIC/multiplexed-transport comment here is misleading: this overload always passes networkTransport: "tcp", and it doesn’t attempt any QUIC detection. Please update/remove the comment (or adjust the logic) so the documented behavior matches the implementation.

Suggested change

// There isn't an easy way to detect whether QUIC is the underlying transport from a feature collection alone.

// This code assumes that a multiplexed connection is QUIC.

// Improve in the future if there are additional multiplexed connection types.

// This overload only has endpoint information from the feature collection and does not attempt

// to infer whether the underlying transport is multiplexed or QUIC. For IP endpoints, it records

// the transport as TCP.

Copilot · 2026-04-10T01:08:12Z

src/Shared/ConnectionEndpointTags.cs

+using Microsoft.AspNetCore.Http.Features;
+
+#nullable enable
+


This new shared utility is declared in the global namespace. In src/Shared, shared types are normally placed in an explicit namespace (e.g., Microsoft.AspNetCore.Shared in Diagnostics/ActivityCreator.cs), which helps avoid accidental collisions and keeps call sites consistent. Consider moving this type into an appropriate shared namespace and updating call sites accordingly.

Suggested change

namespace Microsoft.AspNetCore.Shared;

Copilot · 2026-04-10T01:08:12Z

src/Servers/IIS/IIS/src/Core/IISHttpContext.Features.cs

    private static readonly Type IHttpResponseTrailersFeature = typeof(global::Microsoft.AspNetCore.Http.Features.IHttpResponseTrailersFeature);
    private static readonly Type IHttpResetFeature = typeof(global::Microsoft.AspNetCore.Http.Features.IHttpResetFeature);
    private static readonly Type IConnectionLifetimeNotificationFeature = typeof(global::Microsoft.AspNetCore.Connections.Features.IConnectionLifetimeNotificationFeature);
+    private static readonly Type IConnectionEndPointFeatureType = typeof(global::Microsoft.AspNetCore.Connections.Features.IConnectionEndPointFeature);


Naming nit: the static Type field for the feature is IConnectionEndPointFeatureType, but the adjacent connection feature (IConnectionLifetimeNotificationFeature) doesn’t use the Type suffix. Consider renaming for consistency with the existing feature-type field naming in this file.

Suggested change

private static readonly Type IConnectionEndPointFeatureType = typeof(global::Microsoft.AspNetCore.Connections.Features.IConnectionEndPointFeature);

private static readonly Type IConnectionEndPointFeature = typeof(global::Microsoft.AspNetCore.Connections.Features.IConnectionEndPointFeature);

Initial plan for issue

04cf3eb

Copilot AI assigned Copilot and BrennanConroy May 29, 2025

Copilot started work on behalf of BrennanConroy May 29, 2025 20:23 View session

dotnet-policy-service bot added the Attention: Shared Code Modified label May 29, 2025

Implement IConnectionEndPointFeature in TransportConnection

55b9034

Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] What are we doing with IConnectionEndPointFeature~~ Implement IConnectionEndPointFeature in Kestrel's TransportConnection May 29, 2025

Copilot AI requested a review from BrennanConroy May 29, 2025 20:43

Copilot finished work on behalf of BrennanConroy May 29, 2025 20:43

Copilot started work on behalf of BrennanConroy May 29, 2025 23:52 View session

Add TransportConnection IConnectionEndPointFeature tests

dbd9f49

Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Copilot finished work on behalf of BrennanConroy May 30, 2025 00:03

Copilot started work on behalf of BrennanConroy June 7, 2025 02:45 View session

Refactor connection endpoint tagging to use shared utility

6c1244f

Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Copilot finished work on behalf of BrennanConroy June 7, 2025 03:01

BrennanConroy added 2 commits June 6, 2025 20:17

Update KestrelMetrics.cs

9cfe40b

Update KestrelMetrics.cs

c4f48b6

Copilot started work on behalf of BrennanConroy June 9, 2025 16:34 View session

Add IConnectionEndPointFeature support to TransportMultiplexedConnect…

45fbce8

…ion for HTTP/3 Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Copilot finished work on behalf of BrennanConroy June 9, 2025 16:53

Copilot started work on behalf of BrennanConroy June 9, 2025 20:54 View session

Add IConnectionEndPointFeature support to HttpConnectionContext and S…

630a05c

…ignalR endpoint tags test Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Copilot finished work on behalf of BrennanConroy June 9, 2025 21:09

BrennanConroy mentioned this pull request Jun 26, 2025

Initialize hosting trace with OTEL tags for sampling #62090

Merged

4 tasks

github-actions bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Feb 10, 2026

Copilot started work on behalf of BrennanConroy April 4, 2026 04:58 View session

Copilot AI and others added 2 commits April 4, 2026 05:06

Merge main into copilot/fix-43786 to update PR

6708082

Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Fix code quality issues: refactor ConnectionEndpointTags.cs and fix t…

af13f19

…est compile errors Agent-Logs-Url: https://github.com/dotnet/aspnetcore/sessions/0a5a6edd-af5f-4fce-96d9-3d2ed8c69a2c Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Copilot finished work on behalf of BrennanConroy April 4, 2026 05:21

Copilot started work on behalf of BrennanConroy April 5, 2026 04:03 View session

Copilot AI and others added 2 commits April 5, 2026 04:20

Undo submodule change; add IConnectionEndPointFeature to HttpSys and IIS

dfbd1b6

Agent-Logs-Url: https://github.com/dotnet/aspnetcore/sessions/63be0905-83a8-4217-b93d-63c59108c821 Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Restore googletest submodule to main branch version (d72f9c8a)

93ed79f

Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Copilot AI changed the title ~~Implement IConnectionEndPointFeature in Kestrel's TransportConnection~~ Implement IConnectionEndPointFeature in Kestrel, HttpSys, and IIS Apr 5, 2026

Copilot finished work on behalf of BrennanConroy April 5, 2026 04:25

Copilot started work on behalf of BrennanConroy April 6, 2026 19:47 View session

Add smoke tests for IConnectionEndPointFeature in HttpSys and IIS

49c4fd8

Agent-Logs-Url: https://github.com/dotnet/aspnetcore/sessions/6555e55e-2ba8-4ee0-8af9-2a28cdf45b12 Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Copilot finished work on behalf of BrennanConroy April 6, 2026 19:56

build-analysis bot mentioned this pull request Apr 8, 2026

Sometimes the helix SDK uses GetWorkItemsAsync when workitems aren't done processing. dotnet/dnceng#6011

Open

3 tasks

Merge branch 'main' into copilot/fix-43786

5bfaea5

BrennanConroy marked this pull request as ready for review April 10, 2026 01:03

BrennanConroy requested a review from halter73 as a code owner April 10, 2026 01:03

Copilot AI review requested due to automatic review settings April 10, 2026 01:03

Copilot started reviewing on behalf of BrennanConroy April 10, 2026 01:03 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

	private static readonly Type IConnectionEndPointFeatureType = typeof(global::Microsoft.AspNetCore.Connections.Features.IConnectionEndPointFeature);
	private static readonly Type IConnectionEndPointFeature = typeof(global::Microsoft.AspNetCore.Connections.Features.IConnectionEndPointFeature);

Conversation

Copilot AI commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Usage

Notes

Uh oh!

BrennanConroy commented May 29, 2025

Uh oh!

Copilot AI commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

BrennanConroy commented Jun 7, 2025

Uh oh!

Copilot AI commented Jun 7, 2025

Uh oh!

BrennanConroy commented Jun 9, 2025

Uh oh!

Copilot AI commented Jun 9, 2025

Uh oh!

BrennanConroy commented Jun 9, 2025

Uh oh!

Copilot AI commented Jun 9, 2025

Uh oh!

BrennanConroy commented Apr 4, 2026

Uh oh!

Copilot AI commented Apr 4, 2026

Uh oh!

BrennanConroy commented Apr 5, 2026

Uh oh!

Copilot AI commented Apr 5, 2026

Uh oh!

BrennanConroy commented Apr 6, 2026

Uh oh!

Copilot AI commented Apr 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 29, 2025 •

edited

Loading

Copilot AI commented May 30, 2025 •

edited

Loading