Prevent InvalidCastException when attribute type does not match parameter type by adding safe type conversion.#66137
Open
minaxi98 wants to merge 2 commits intodotnet:mainfrom
Conversation
…eter type by adding safe type conversion. Fixes dotnet#60019
Contributor
|
Thanks for your PR, @minaxi98. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
This was referenced Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent InvalidCastException when attribute type does not match parameter type by adding safe type conversion.
Summary of the changes (Less than 80 chars)
Description
The problem: when DefaultParameterValue(10) is used on a uint64 parameter, the 10 is a boxed int32, and JsonSerializer.SerializeToNode calls UnboxOnWrite which can't directly unbox an int32.
The fix: convert defaultValue to the target type before serializing:
Fixes #60019 (in this specific format)