[main] Source code updates from dotnet/dotnet#66239
[main] Source code updates from dotnet/dotnet#66239dotnet-maestro[bot] wants to merge 3 commits intomainfrom
Conversation
[[ commit created by automation ]]
Updated Dependencies: Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 11.0.0-preview.4.26203.108 -> 11.0.0-preview.4.26208.110) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 11.0.0-beta.26203.108 -> 11.0.0-beta.26208.110) Microsoft.Web.Xdt (Version 3.3.0-preview.4.26203.108 -> 3.3.0-preview.4.26208.110) NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.6.0-rc.20408 -> 7.6.0-rc.20910) [[ commit created by automation ]]
dotnet-maestro
bot
requested review from
a team,
BrennanConroy,
halter73 and
wtgodbe
as code owners
github-actions
bot
added
the
area-infrastructure
![dotnet-policy-service[bot]](https://avatars.githubusercontent.com/in/285228?s=60&v=4){kind=small}
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
| <clear /> | ||
| <!--Begin: Package sources managed by Dependency Flow automation. Do not edit the sources below.--> | ||
| <!-- Begin: Package sources from dotnet-extensions --> | ||
| <add key="darc-pub-dotnet-extensions-24c7e4f" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-extensions-24c7e4fc/nuget/v3/index.json" /> |
There was a problem hiding this comment.
@dotnet/prodconsvcs it looks like this feed gets removed by mistake, it causes restore failures on the PR
There was a problem hiding this comment.
@akoeplinger did the failures you saw get fixed by adding this specific feed back?
I have a little script that uses darc to list all the feed locations that should be used based on a Version.Details.xml file, and it's showing me that the following feed would be needed here:
darc-pub-dotnet-extensions-0034cc0f
There was a problem hiding this comment.
@adamzip yes this got fixed, it's hitting other issues now
@ericstj fallout from dotnet/dotnet#5206 |
Theory - this is a latent dead code issue in the library. It includes a resource class even though it has no resources. Now that it's part of the shared framework, it's trimmed, and that's all removed. The ILLink.Substitutions.xml comes from https://github.com/dotnet/runtime/blob/a181406886335da69df0c5bdc9a67ea5940ff116/eng/ILLink.Substitutions.Resources.template which is added by https://github.com/dotnet/runtime/blob/a181406886335da69df0c5bdc9a67ea5940ff116/eng/illink.targets#L131. I think the fix here would be to remove the unused resx from this assembly so it doesn't get this injected trimming file. I'll see about reproducing here and adding a workaround until we can get that fix in a new VMR build. |
|
I've confirmed this theory with a local build. Will make a fix. Seeing about a workaround. |
|
Ok, fix will go into both runtime and VMR. We could workaround this with |
5 participants
Note
This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Updated Dependencies
Associated changes in source repos
Diff the source with this PR branch