Update docs and infrastructure to target .NET 11.0 private builds#5125
Update docs and infrastructure to target .NET 11.0 private builds#5125LoopedBard3 merged 7 commits intomainfrom
Conversation
Update all documentation examples and paths to reference net11.0 TFM and 11.0.0 version folders instead of the stale net9.0/9.0.0 values, matching the current dotnet/runtime build output. Files changed: - docs/benchmarking-workflow-dotnet-runtime.md: 51 net9.0->net11.0, 20 9.0.0->11.0.0 - docs/profiling-workflow-dotnet-runtime.md: 5 references updated - src/benchmarks/micro/README.md: Private build paths updated - global.net11.json: New SDK config for .NET 11 preview Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
copilot was having terrible trouble running benchmarks against private changes, at least partly because it was trusting these docs... |
Match the versions used in the main global.json rather than copying the 10.0.0-beta versions from global.net10.json. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The main global.json already targets .NET 11 SDK. The global.netX.json files are only used by CI (ci_setup.py) to downgrade the SDK when testing older .NET versions. A global.net11.json would only be needed in the future when global.json moves to .NET 12. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
markdownlint-cli 0.47.0 requires Node >= 20 (uses /v regex flag). Also bump checkout and setup-node from v3 to v4 (v3 is deprecated). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates repo documentation examples to align with current dotnet/runtime private build outputs by switching stale net9.0 / 9.0.0 references to net11.0 / 11.0.0.
Changes:
- Updated benchmarking workflow documentation commands/paths to use
net11.0and11.0.0. - Updated profiling workflow documentation to reference
net11.0testhost paths and sample TFM. - Updated MicroBenchmarks README CoreRun path examples for private runtime builds.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
docs/benchmarking-workflow-dotnet-runtime.md |
Refreshes runtime build paths/TFMs; includes a couple of doc-command formatting/flag issues to fix. |
docs/profiling-workflow-dotnet-runtime.md |
Updates testhost paths and sample TargetFramework to net11.0. |
src/benchmarks/micro/README.md |
Updates CoreRun example paths to net11.0 / 11.0.0; has an inconsistent flag casing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- -aotcompilermode -> --aotcompilermode (missing dash) - Broken closing code fence (line 616) - --corerun -> --coreRun (consistent casing) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Upgrading Node.js to 20 allows markdownlint-cli 0.47 to run, which includes the new MD060 rule. The repo has many pre-existing table alignment issues (e.g., basic-scenarios.md) so disable this rule to match the previous effective behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The --bdn-arguments=""..."" pattern passes an empty string + separate tokens instead of a single quoted value. Fix to --bdn-arguments="..." matching the correct pattern used in the wasm sections. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
ready for review |
|
This looks good to me, thank you for the contribution! |
Update all documentation examples and paths to reference net11.0 TFM and 11.0.0 version folders instead of the stale net9.0/9.0.0 values, matching the current dotnet/runtime build output.
Changes
net9.0→net11.0and 209.0.0→11.0.0path references across CLR, wasm, MonoAOT, MonoInterpreter, Mono JIT, and Preventing Regressions sections--coreRunexample paths in Private Runtime Builds sectionAlso fixes pre-existing issues spotted by reviewer:
-aotcompilermode→--aotcompilermode(missing dash)```cmd→```)--corerun→--coreRun(consistent casing)Not changed (already up to date)
scripts/dotnet.py— already hasnet11.0supportMicroBenchmarks.csproj— already hasnet11.0in SupportedTargetFrameworks