Add LeadingStrings benchmarks for binary and non-ASCII regex patterns#5126
Open
danmoseley wants to merge 2 commits intodotnet:mainfrom
Open
Add LeadingStrings benchmarks for binary and non-ASCII regex patterns#5126danmoseley wants to merge 2 commits intodotnet:mainfrom
danmoseley wants to merge 2 commits intodotnet:mainfrom
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds two new benchmark classes to test regex alternation pattern performance with different input types. The benchmarks are designed to validate that the LeadingStrings vs FixedDistanceSets heuristic in the regex engine doesn't regress on binary and non-ASCII data.
Changes:
- Added
Perf_Regex_LeadingStrings_BinaryDataclass with benchmarks for binary data patterns (1MB PE-header-like corpus) - Added
Perf_Regex_LeadingStrings_NonAsciiclass with benchmarks for Russian text patterns (~100KB from Anna Karenina)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/benchmarks/micro/libraries/System.Text.RegularExpressions/Perf.Regex.LeadingStrings.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two new benchmark classes to exercise the LeadingStrings vs FixedDistanceSets heuristic in the regex engine:
Companion to dotnet/runtime change: dotnet/runtime#124736