Skip to content

Conversation

@huoyaoyuan
Copy link
Member

Also moves ThreadStartException to managed code.

The general question is about where RaiseException is required instead of DispatchManagedException. I played a bit with it in QCall and DispatchManagedException seems to interop directly with C++ EH on Windows. UnwindAndContinueRethrowHelperAfterCatch(nativeRethrow) is intentional, but HandleThreadAbort doesn't look like.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 4, 2026
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member

jkotas commented Jan 4, 2026

The test failure looks related:

  Starting:    System.Diagnostics.Process.Tests (parallel test collections = on [2 threads], stop on fail = off)
    System.Diagnostics.Tests.ProcessStartInfoTests.TestWindowStyle [SKIP]
      Condition(s) not met: "IsAdmin_IsNotNano_RemoteExecutorIsSupported"
    System.Diagnostics.Tests.ProcessStartInfoTests.Verbs_GetWithExeExtension_ReturnsExpected [SKIP]
      Condition(s) not met: "IsNotWindowsNanoServer"
    System.Diagnostics.Tests.ProcessStartInfoTests.ShellExecute_Nano_Fails_Start [FAIL]
      Assert.Throws() Failure: Exception type was not an exact match
      Expected: typeof(System.Threading.ThreadStartException)
      Actual:   typeof(System.Threading.ThreadStateException)
      ---- System.Threading.ThreadStateException : Thread has not been started.

@jkotas
Copy link
Member

jkotas commented Jan 6, 2026

Could you please resolve the conflict?

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@janvorli Could you please take a look as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-ExceptionHandling-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants