Improve jit-regression-test skill with structured description and stop signals#124734
Open
lewing wants to merge 1 commit intodotnet:mainfrom
Open
Improve jit-regression-test skill with structured description and stop signals#124734lewing wants to merge 1 commit intodotnet:mainfrom
lewing wants to merge 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the jit-regression-test skill documentation with better structured descriptions, explicit stop signals, and consolidated tips to enhance skill activation accuracy and prevent misapplication.
Changes:
- Added USE FOR / DO NOT USE FOR routing keywords to the skill description for better activation matching
- Added blockquote stop signal (line 15) specifying when NOT to create tests (no repro, duplicate, non-JIT bugs)
- Consolidated tips from 4 verbose items to 2 concise items, removing duplicates of conventions already covered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve the jit-regression-test skill with structured description, stop signals, and consolidated tips.
Changes
Structured description — Added USE FOR / DO NOT USE FOR routing keywords for better skill activation. Trigger phrases include: creating JIT regression tests, extracting repro code, "write a test for this JIT bug", "create a regression test for issue #NNNNN". Anti-triggers: non-JIT tests, debugging without repro, performance benchmarks.
Stop signal blockquote — Added explicit guidance on when NOT to create a test (no reproducible code, duplicate of existing test, bug is in libraries not JIT). This prevents the skill from being misapplied on invalid inputs.
Consolidated tips — Reduced from 4 verbose items to 2 concise items. Removed tips that duplicate the conventions section (NoInlining, minimize repro).
Validation
Multi-model eval results (5 questions testing trigger routing, stop compliance, structural output, convention compliance, negative routing):
Key improvement: Haiku stop-signal compliance went from 2/5 to 5/5. The blockquote pattern causes weaker models to correctly refuse when stop conditions are met, rather than inferring from general knowledge.
Context
These patterns (structured descriptions, blockquote stop signals) are documented in the Copilot Skills Guidance and have been validated across multiple skills (ci-analysis, flow-analysis, flow-tracing).