Enable additional event listener logging in TimeInQueue_RecordedForNewConnectionsOnly#124740
Draft
kuba1 wants to merge 3 commits intodotnet:mainfrom
Draft
Enable additional event listener logging in TimeInQueue_RecordedForNewConnectionsOnly#124740kuba1 wants to merge 3 commits intodotnet:mainfrom
kuba1 wants to merge 3 commits intodotnet:mainfrom
Conversation
…wConnectionsOnly This change enables and prints to test output event listener entries from System.Net.Http allowing to see what's happening inside HttpConnectionPool when this test is run. This in turn will hopefully help to diagnose why the test is failing.
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
Author
|
@dotnet-policy-service agree |
ManickaP
reviewed
Feb 23, 2026
|
|
||
| return LoopbackServerFactory.CreateClientAndServerAsync(async uri => | ||
| { | ||
| using var eventListener = new NetEventListener(_output); |
Member
There was a problem hiding this comment.
BTW, there's already TestUtilities.TestEventListener.
Author
There was a problem hiding this comment.
Fixed, thanks. Looks much better indeed.
Use TestEventListener from TestUtilities to listen to relevant HTTP events. Simplify additional logging as it's unnecessarily verbose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables and prints to test output event listener entries from System.Net.Http allowing to see what's happening inside HttpConnectionPool when this test is run. This in turn will hopefully help to diagnose why the test is failing.