Fix insufficient contrast for PropertyGrid dropdown text in Dark Mode#14152
Open
LeafShi1 wants to merge 1 commit intodotnet:mainfrom
Open
Fix insufficient contrast for PropertyGrid dropdown text in Dark Mode#14152LeafShi1 wants to merge 1 commit intodotnet:mainfrom
LeafShi1 wants to merge 1 commit intodotnet:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14152 +/- ##
===================================================
+ Coverage 77.15180% 77.15493% +0.00312%
===================================================
Files 3279 3279
Lines 645333 645334 +1
Branches 47720 47721 +1
===================================================
+ Hits 497886 497907 +21
+ Misses 143754 143740 -14
+ Partials 3693 3687 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
SimonZhao888
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14120
Root Cause
The
DesignBindingPicker(used forDataSource/DisplayMemberproperty editors) were applying theExplorertheme regardless of the color mode. In Dark Mode, this caused insufficient contrast for the None text and other items, especially when selected.Proposed changes
DesignerUtils.cs: ModifiedApplyTreeViewThemeStylesmethod to applyDarkMode_Explorertheme whenApplication.IsDarkModeEnabledis true, otherwise useExplorerthemeCustomer Impact
DataSource,DisplayMemberRegression?
Risk
Screenshots
Before
Insufficient contrast for the "None" text in the Dropdown Panel for the DataSource/DisplayMemeber properties in the DarkMode

After
The contrast of the text "None" is sufficient.
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow