Fix TabControl spinner button not applying Dark Mode when TabPages added dynamically#14162
Open
LeafShi1 wants to merge 1 commit intodotnet:mainfrom
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14162 +/- ##
===================================================
+ Coverage 77.15180% 77.15607% +0.00427%
===================================================
Files 3279 3279
Lines 645333 645340 +7
Branches 47720 47721 +1
===================================================
+ Hits 497886 497919 +33
+ Misses 143754 143731 -23
+ Partials 3693 3690 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14159
Root Cause:
Proposed changes
WM_PARENTNOTIFYmessage handling in TabControl's WndProc method to apply Dark Mode theme to dynamically created child windows (specifically the spinner button).Customer Impact
Regression?
Risk
Screenshots
Before
The Spinner button of Tabcontrol not in DarkMode when adding the TabPage items by using TabPages property in the PropretyGrid control
TabControlIssue.mp4
After
Dynamically created TabControl child windows (spinner buttons) now automatically receive Dark Mode theme when created
AfterChange.mp4
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow