Fail deploy when /reload-theme can't recover#36
Open
superterran wants to merge 1 commit into
Open
Conversation
The reload_theme step previously returned success on any non-2xx/302 response, so a 500 from Micro.blog would log a warning and the deploy job would still exit green — masking real failures (e.g. wrong theme ID or upstream outage). Now retries 3x with exponential backoff (2s, 4s) on 5xx and network errors, then fails hard with a ::error:: annotation so the workflow turns red and the failure is visible in the Actions UI. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
::error::annotation, so the workflow turns red and the failure surfaces in the Actions UI./account/themes/reloadprinted a warning and the job exited green — so a broken theme ID or upstream outage produced a silent no-op deploy.Test plan
MICROBLOG_THEME_IDat an invalid value and confirm the workflow fails with the new::error::annotation after 3 attempts.🤖 Generated with Claude Code