Skip to content

fix: 消除空指针 #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hjxp merged 2 commits into from
Sep 18, 2025
Merged

fix: 消除空指针 #681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58003c6
消除空指针
Aug 21, 2025
eb6267f
removeleftmargin
Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/src/pages/monitor/pannel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ function GrafanaPannel(props: any) {
position: 'relative',
display: 'flex',
flex: 'auto',
marginLeft: iframeVisible ? 0 : -60,
marginLeft: 0,
flexDirection: 'column',
justifyContent: 'center',
alignItems: 'center',
Expand Down
3 changes: 1 addition & 2 deletions internal/pkg/service/k8s/pod.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,10 +276,9 @@ func (i *syncPod) update(old interface{}, new interface{}) {
func (i *syncPod) delete(obj interface{}) {
in, ok := obj.(*v1.Pod)
if !ok {
xlog.Warn("k8sWork",
xlog.Warn("k8sWork not ok",
xlog.String("step", "add-check"),
Copy link

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message "k8sWork not ok" is unclear and doesn't provide meaningful context. Consider using a more descriptive message like "failed to cast object to Pod" or "invalid pod object type".

Suggested change
xlog.String("step", "add-check"),
xlog.Warn("failed to cast object to Pod",
xlog.String("step", "delete-type-assertion"),

Copilot uses AI. Check for mistakes.
xlog.String("zoneCode", i.zoneCode),
xlog.String("podName", in.Name),
xlog.Any("obj", obj),
xlog.String("reason", "type error"))
return
Expand Down