Skip to content

Update __WinHttpHTML5FormAttribs for Au3Check#14

Open
seadoggie01 wants to merge 1 commit into
dragana-r:masterfrom
seadoggie01:patch-1
Open

Update __WinHttpHTML5FormAttribs for Au3Check#14
seadoggie01 wants to merge 1 commit into
dragana-r:masterfrom
seadoggie01:patch-1

Conversation

@seadoggie01

Copy link
Copy Markdown

Updated to have no issues with strictest Au3Check parameters: -d -w 1 -w 2-w 3 -w 4 -w 5 -w 6
Moved variable declarations to outside of loops and If statements

Updated to have no issues with strictest Au3Check parameters: -d -w 1 -w 2-w 3 -w 4 -w 5 -w 6
Moved variable declarations to outside of loops and `If` statements
@mlipok

mlipok commented Apr 25, 2021

Copy link
Copy Markdown

Some similar pr was here
#8

@seadoggie01

Copy link
Copy Markdown
Author

I see... I looked for pull requests, but not closed ones. 😒 I use the strict Au3Check settings and so I have to keep these changes. I might end up forking and maintaining a separate copy, ugh

@mlipok

mlipok commented Apr 25, 2021

Copy link
Copy Markdown

I know.
For the same reasons I use a modified UDF, because otherwise the projects that use it could not be implemented easily enough for me.

@seadoggie01

Copy link
Copy Markdown
Author

Per the wiki, it is best practice (in AutoIt) to declare variables outside of loops: https://www.autoitscript.com/wiki/Best_coding_practices#Scopes_of_Variables (near the end of the section)
Declaring inside loops has an impact on performance... albeit small

@mlipok

mlipok commented Apr 26, 2021

Copy link
Copy Markdown

Per the wiki, it is best practice (in AutoIt) to declare variables outside of loops: https://www.autoitscript.com/wiki/Best_coding_practices#Scopes_of_Variables (near the end of the section)
Declaring inside loops has an impact on performance... albeit small

I think that @dragana-r know this very well.
This can be "by desing/intentional usage ", but I do not know why.

rcmaehl added a commit to rcmaehl/autoit-winhttp that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants