[Misc] Return suggested value for constraint funcs by ziyilin · Pull Request #878 · dragonwell-project/dragonwell11

ziyilin · 2024-10-28T01:41:57Z

Verify JVM parameters, print out suggested values for violations instead of error message.

Enable by -XX:+VerifyFlagConstraints.

CLAassistant · 2024-10-28T01:42:03Z

All committers have signed the CLA.

kuaiwei · 2024-12-02T01:58:14Z

src/hotspot/share/runtime/globals.hpp

+  diagnostic(bool, VerifyFlagConstraints, false,                            \
+          "Verify flags, calculate suggested legal values for that "        \
+          "violate the constraints, and then exit VM")                      \
+                                                                            \


我们添加的参数建议放在globals_ext.hpp中

kuaiwei · 2024-12-04T07:24:00Z

src/hotspot/share/gc/cms/jvmFlagConstraintsCMS.cpp

  // CMSWorkQueueDrainThreshold is verified to be less than max_juint
  if (UseConcMarkSweepGC && (threads > (uint)(max_jint / (uint)threshold))) {
+    if (VerifyFlagConstraints) {
+      //JVMFlag::printError(true, "ParallelGCThreads:"UINT32_FORMAT"\n", )


这里为什么不修复并报错，而是直接返回了

目前先不支持CMS，我把这里的检查去掉了

kuaiwei · 2024-12-04T07:36:38Z

src/hotspot/share/gc/shared/jvmFlagConstraintsGC.cpp


  if (status == JVMFlag::SUCCESS) {
-    status = CheckMaxHeapSizeAndSoftRefLRUPolicyMSPerMB(value, SoftRefLRUPolicyMSPerMB, verbose);
+    if ((SoftRefLRUPolicyMSPerMB > 0) && ((value / M) > (max_uintx / SoftRefLRUPolicyMSPerMB))) {


为什么这里要展开这个方法？

CheckMaxHeapSizeAndSoftRefLRUPolicyMSPerMB原先被SoftRefLRUPolicyMSPerMBConstraintFunc和MaxHeapSizeConstraintFunc公用，原先分别在两个use里展开就不用检查来源了。不过还是应该提高复用度，已经修改了CheckMaxHeapSizeAndSoftRefLRUPolicyMSPerMB函数的声明，增加了来源。

kuaiwei · 2024-12-04T07:42:22Z

src/hotspot/share/gc/shared/jvmFlagConstraintsGC.cpp

 #ifdef COMPILER2
 #include "opto/c2_globals.hpp"
 #endif // COMPILER2
+#include <cmath>


这个文件是必须要加的吗

kuaiwei · 2024-12-04T07:50:15Z

src/hotspot/share/runtime/flags/jvmFlagConstraintsRuntime.cpp

 #include "runtime/globals.hpp"
 #include "runtime/safepointMechanism.hpp"
 #include "runtime/task.hpp"
+#include <cmath>


不要引入这个文件

kuaiwei · 2024-12-04T07:51:06Z

src/hotspot/share/runtime/flags/jvmFlagConstraintsRuntime.cpp

+    if (VerifyFlagConstraints) {
+      verifyFailed = true;
+      int logValue = log2_intptr(value);
+      value = (intx)pow(2, logValue);


改成 1 << logValue 即可

kuaiwei · 2024-12-04T07:51:54Z

src/hotspot/share/gc/shared/jvmFlagConstraintsGC.cpp

+      if (VerifyFlagConstraints) {
+        verifyFailed = true;
+        int logValue = log2_intptr(value);
+        value = (intx)pow(2, logValue);


改成 1 << logValue

kuaiwei · 2024-12-04T07:52:48Z

src/hotspot/share/runtime/flags/jvmFlagConstraintsCompiler.cpp

 #include "runtime/flags/jvmFlagConstraintsCompiler.hpp"
 #include "runtime/globals.hpp"
 #include "runtime/globals_extension.hpp"
+#include <cmath>


不要引入这个文件

kuaiwei · 2024-12-04T07:55:35Z

src/hotspot/share/runtime/flags/jvmFlagConstraintsCompiler.cpp

      return JVMFlag::VIOLATES_CONSTRAINT;
    }
-
+    //InvocationCounter::count_shift = 3


remove this line

kuaiwei · 2024-12-04T07:57:16Z

src/hotspot/share/runtime/flags/jvmFlagConstraintsCompiler.cpp

-                        "larger than or equal to CodeEntryAlignment (" INTX_FORMAT ") "
-                        "to align entry points\n",
-                        CodeCacheSegmentSize, CodeEntryAlignment);
+                          "CodeCacheSegmentSize  (" UINTX_FORMAT ") must be "


不用修改格式

kuaiwei · 2024-12-04T07:58:48Z

src/hotspot/share/runtime/flags/jvmFlagConstraintsCompiler.cpp

 }

 JVMFlag::Error CodeEntryAlignmentConstraintFunc(intx value, bool verbose) {
+  // Don't apply VerifyFlagConstraints here because CodeEntryAlignment is not production parameter.


这个方法的改动好像都不需要

Summary: Return suggested option value when it violates the constraints. Exit the VM after all input options are checked. Testing: JTreg Reviewers: Kuaiwei, wenjie Issue: dragonwell-project#894

ziyilin force-pushed the printConstraintFuncs branch from 7377313 to ab920bd Compare October 29, 2024 08:35

ziyilin changed the title ~~Print constraint funcs~~ [Misc] Return suggested value for constraint funcs Nov 26, 2024

ziyilin force-pushed the printConstraintFuncs branch 2 times, most recently from aa883b3 to bda9bf3 Compare November 26, 2024 08:55

kuaiwei reviewed Dec 2, 2024

View reviewed changes

kuaiwei reviewed Dec 4, 2024

View reviewed changes

ziyilin force-pushed the printConstraintFuncs branch 2 times, most recently from b204782 to 92d3bd5 Compare December 5, 2024 09:52

[Misc] Return suggested value when violate option constraints

4f2ef01

Summary: Return suggested option value when it violates the constraints. Exit the VM after all input options are checked. Testing: JTreg Reviewers: Kuaiwei, wenjie Issue: dragonwell-project#894

ziyilin force-pushed the printConstraintFuncs branch from 92d3bd5 to 4f2ef01 Compare January 20, 2025 03:05

Conversation

ziyilin commented Oct 28, 2024

Uh oh!

CLAassistant commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CLAassistant commented Oct 28, 2024 •

edited

Loading