Skip to content

[JIT] Fix test issues about jtune#303

Merged
MaxXSoft merged 1 commit intomasterfrom
fix-jtune-tests
Feb 28, 2026
Merged

[JIT] Fix test issues about jtune#303
MaxXSoft merged 1 commit intomasterfrom
fix-jtune-tests

Conversation

@MaxXSoft
Copy link
Copy Markdown
Collaborator

Summary: In AI-Extension, jtune is a shell script located in the bin directory of the Java home, and it does not accept command-line options such as -h or -version. Therefore, we should skip tests that attempt to check for these.

Testing: TestCheckJDK.java, HelpFlagsTest.java, VersionCheck.java

Reviewers: kuaiwei, JoshuaZhuwj

Issue: #302

Summary: In AI-Extension, jtune is a shell script located in the bin
directory of the Java home, and it does not accept command-line options
such as -h or -version. Therefore, we should skip tests that attempt to
check for these.

Testing: TestCheckJDK.java, HelpFlagsTest.java, VersionCheck.java

Reviewers: kuaiwei, JoshuaZhuwj

Issue: #302
Copy link
Copy Markdown
Collaborator

@JoshuaZhuwj JoshuaZhuwj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaxXSoft
Copy link
Copy Markdown
Collaborator Author

Confirmed with @Ann-1024 that some GHA checks are failing due to a runner issue, this is not a problem with the PR, so it is safe to merge this patch.

@MaxXSoft MaxXSoft merged commit aaa7da5 into master Feb 28, 2026
310 of 324 checks passed
@MaxXSoft MaxXSoft deleted the fix-jtune-tests branch February 28, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants