fix: drone service wrong port and runner wrong mount#112
Open
liu-xuewen wants to merge 1 commit intodrone:masterfrom
Open
fix: drone service wrong port and runner wrong mount#112liu-xuewen wants to merge 1 commit intodrone:masterfrom
liu-xuewen wants to merge 1 commit intodrone:masterfrom
Conversation
Contributor
|
You can set the drone server port to 80 in your values yaml file if needed, we shouldn't have to change the default from 8080 to 80. Unless I'm missing something? Can you submit a different PR with the dind change? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drone service port 8080 will cause fail errors: curl -X POST http://drone/rpc/v2/ping
drone-runner-docker wrong mount will cause fail errors: docker not found