This repository was archived by the owner on Apr 24, 2018. It is now read-only.
Parameters specified in the routes themselves are never decoded#11
Open
ecton wants to merge 1 commit intodrone:masterfrom
Open
Parameters specified in the routes themselves are never decoded#11ecton wants to merge 1 commit intodrone:masterfrom
ecton wants to merge 1 commit intodrone:masterfrom
Conversation
|
First comment on first pull :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes parameters within a URL be decoded, just like the regular query parameters. For example, the route "/test/:name/foo" and the path: "/test/Test+User/foo" should result in the string "Test User" for the ":name" key, not "Test+User".
This patch applies that, and in an attempt to keep it from choking on invalid escapes, it defaults back to the original match if QueryUnescape fails. This is my preferred behavior, but doesn't necessarily match what your vision for how this project was meant to process that type of failure.