This repository was archived by the owner on Apr 24, 2018. It is now read-only.
ResponseWriter now implements CloseNotifier interface#18
Open
sharkone wants to merge 1 commit intodrone:masterfrom
Open
ResponseWriter now implements CloseNotifier interface#18sharkone wants to merge 1 commit intodrone:masterfrom
sharkone wants to merge 1 commit intodrone:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
here's a PR to implement the CloseNotifier on the ResponseWriter, allowing the user to be notified when a connection closes.
There are also some minor cleanups introduced by gofmt.