Make empty menu an error #154
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change the empty menu could either be represented by `Left NoLunch` or `Right []`, which introduces an unnecessary ambiguity. This commit does not let a menu be empty by using the excellent `NonEmpty` type, and then doing all the necessary changes in the code base.
Rembane
requested review from
Eggez,
Eplutt,
GruvGurra,
Jassob,
Rodeby1 and
The1Penguin
Jassob
reviewed
Dec 27, 2025
Contributor
Jassob
left a comment
Jassob
left a comment
There was a problem hiding this comment.
Looks solid enough to me!
The1Penguin
reviewed
Dec 27, 2025
The1Penguin
approved these changes
Dec 27, 2025
Contributor
The1Penguin
left a comment
The1Penguin
left a comment
There was a problem hiding this comment.
Think about what I mentioned in my other comment, it doesn't really matter either way. Good idea :D
...after feedback from Pingu. This lets us remove an import if we're ready to deconstruct the list and then reconstruct it as a non empty list. It produces surprisingly pretty code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change the empty menu could either be represented by
Left NoLunchorRight [], which introduces an unnecessary ambiguity. This commit does not let a menu be empty by using the excellentNonEmptytype, and then doing all the necessary changes in the code base.