Set MSRV 1.85 & set stable toolchain #273
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates the Rust toolchain from a nightly version to stable and sets the MSRV to 1.85, while making minor code improvements including removing unnecessary type conversions and optimizing loop calculations.
Changes:
- Updated Rust toolchain from nightly-2023-11-10 to stable channel
- Set minimum supported Rust version (MSRV) to 1.85 in Cargo.toml
- Optimized permutation loop logic to avoid redundant calculations
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Added rust-version field specifying MSRV 1.85 |
| rust-toolchain.toml | Changed toolchain channel from nightly to stable |
| rustfmt.toml | Removed wrap_comments configuration option |
| src/hades/permutation.rs | Refactored loop bounds to pre-calculate values and simplify iteration |
| src/hades/permutation/scalar.rs | Removed redundant as_ref() call on input parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Blocked by: dusk-network/plonk#857 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.