Set MSRV 1.85 & use stable toolchain #100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request updates the project to use Rust's stable toolchain and sets the Minimum Supported Rust Version (MSRV) to 1.85. The changes align with Rust 1.85's stabilization of elided lifetimes in associated constant contexts, eliminating the need for a nightly toolchain.
Changes:
- Updated toolchain from nightly-2023-11-10 to stable
- Set MSRV to 1.85 in Cargo.toml files
- Updated lifetime elision syntax to use explicit
'_lifetimes - Removed nightly toolchain requirement from documentation
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rust-toolchain.toml | Changed toolchain channel from nightly to stable |
| dusk-merkle/Cargo.toml | Added rust-version = "1.85" |
| poseidon-merkle/Cargo.toml | Added rust-version = "1.85" |
| dusk-merkle/src/node.rs | Updated lifetime elision to explicit '_ |
| dusk-merkle/src/tree.rs | Updated lifetime elision to explicit '_ in three functions |
| dusk-merkle/src/walk.rs | Simplified match expression to if-let statement |
| dusk-merkle/README.md | Removed nightly toolchain requirement note |
| rustfmt.toml | Removed wrap_comments configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Blocked by: dusk-network/plonk#857 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.