Open
Conversation
added 30 commits
December 12, 2018 14:21
- create/remove group - create/remove core_thing & details - structure unittests - bring in most utilities. - group_definition_version functionality in Entity.
State supports nested keys
Add Subscriptions
Only ‘create’ for now but happy to figure how to factor unit tests.
... and now it works end-to-end. While with that: logging level done right.
* Pretty-print State * Implement full-remove * Don’t fail if Lambda package zip not found, just warn
Add support for Lambdas
Python3 support for v2
... as I hit a bug that was difficult to fix under original structure.
v2 feature catch up with ML Inference demo
Owner
Author
Match v1 checklistMain functions:
Below the cutting line, aka lost & found (things I am not motivated to hold the release of V2 for...)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To keep up with new AWS Greengrass features, Greengo needs a better, more modular structure, and ~80% unit test coverage. Some smaller refactoring ideas piled up, too. Now it's time to do it. I am breaking it to modules, adding unit tests, while trying to make it simple.
Refactor goals:
Notes on new design:
Entityis a base class for Greengrass entities -Group,Subscriptions,Lambdas, etc. It contains shared logic for pre- and post- create and remove. Soon it will implement basic dependency management, something like this:create: if dependencies (parents) are not yet created, notify and exit.remove: if dependent entities (children) are not yet removed, remove them first, then remove the entity (chop the whole branch). May be give an option of auto-remove.Concrete entities, like
GrouporSubscriptions, implementdo_createanddo_removemethods, as well as declare their upstream and downstream dependencies.stateis responsible for managing the state.greengrassmodule implements CLI commands. Support 1) create/remove the whole shebang; 2) create/remove individual entities 3) go beyond Greengrass for convinient dev flow, like create/remove Lambda functions of topic rules.