Fix reprinted class source resolution in subclass links#864
Merged
Conversation
Add resolveClassSource() to Tools5eIndex to look up reprinted class sources (e.g. PHB→XPHB). Call it in getSubclassResource() so that subclass file links use the correct class prefix when both PHB and XPHB are included. Add XPHB to homebrew test sources to reproduce. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
resolveClassSource()method inTools5eIndexto resolve reprinted class sources (e.g., PHB → XPHB)getSubclassResource()inTools5eLinkifierto use the resolved class source when generating subclass linksIssue
Resolves #779 - Subclass links were not accounting for reprinted parent classes when generating resource paths.
Details
When a class is reprinted (moved to a new source book), subclass links now correctly follow the parent class to its new source location.