Aspectj 1.9.25 by basilevs · Pull Request #70 · eclipse-aspectj/ajdt

basilevs · 2025-11-03T09:38:48Z

Use the latest released AspectJ.
A script to make AspectJ updates repeatable (updates the version in all required Maven projects, preventing P2 IU resolution aliasing)
Drop support for Java 1.5
Java 25 runtime support in RCPTT (or at least I could not quickly find any issues with it).

These are done in three separate PRs, but each change applied individually can not be tested. I had to merge them all together to produce a reliable build.

Fixes #64
Fixes #65
Fixes #67

This state does not compile.

JDT has been updated and changed interfaces.

basilevs · 2025-11-03T14:53:47Z

@aclement could you please approve the workflow run?

kriegaex · 2025-11-04T10:24:46Z

@basilevs, workflow is running. 🙂

Fixes eclipse-aspectj#64. JDT no longer supports Java older than 1.8: - eclipse-jdt/eclipse.jdt.ui#1685 - eclipse-jdt/eclipse.jdt.ui#1894

basilevs · 2025-11-05T06:27:46Z

When installed in Eclipse Platform 2024-12 this throws:

eclipse.buildId=4.34.0.20241128-0756
java.version=23.0.2
java.vendor=Eclipse Adoptium
BootLoader constants: OS=macosx, ARCH=aarch64, WS=cocoa, NL=en_GE
Framework arguments:  -product org.eclipse.epp.package.committers.product -keyring /Users/vasiligulevich/.eclipse_keyring
Command-line arguments:  -os macosx -ws cocoa -arch aarch64 -product org.eclipse.epp.package.committers.product -keyring /Users/vasiligulevich/.eclipse_keyring -data file:/Users/vasiligulevich/xored/rcptt/ws/pde/

org.eclipse.ajdt.ui
Error
Wed Nov 05 10:26:17 GMT+04:00 2025
Compile error: AssertionError thrown: Attempt to push null on operand stack!

java.lang.AssertionError: Attempt to push null on operand stack!
	at org.aspectj.org.eclipse.jdt.internal.compiler.codegen.OperandStack.push(OperandStack.java:58)
	at org.aspectj.org.eclipse.jdt.internal.compiler.codegen.OperandStack.push(OperandStack.java:84)
	at org.aspectj.org.eclipse.jdt.internal.compiler.codegen.CodeStream.aload(CodeStream.java:305)
	at org.aspectj.ajdt.internal.compiler.ast.AdviceDeclaration.generateProceedMethod(AdviceDeclaration.java:227)
	at org.aspectj.ajdt.internal.compiler.ast.AdviceDeclaration.generateCode(AdviceDeclaration.java:284)
	at org.aspectj.org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.generateCode(TypeDeclaration.java:777)
	at org.aspectj.ajdt.internal.compiler.ast.AspectDeclaration.generateCode(AspectDeclaration.java:297)
	at org.aspectj.org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.generateCode(TypeDeclaration.java:875)
	at org.aspectj.org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.generateCode(CompilationUnitDeclaration.java:403)
	at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.process(Compiler.java:837)
	at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.processCompiledUnits(Compiler.java:458)
	at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:359)
	at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:310)
	at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation(AjBuildManager.java:1102)
	at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performBuild(AjBuildManager.java:276)
	at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild(AjBuildManager.java:189)
	at org.aspectj.ajde.core.internal.AjdeCoreBuildManager.performBuild(AjdeCoreBuildManager.java:105)
	at org.aspectj.ajde.core.AjCompiler.buildFresh(AjCompiler.java:100)
	at org.eclipse.ajdt.core.builder.AJBuilder.build(AJBuilder.java:251)
	at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:1077)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:47)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:296)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:352)
	at org.eclipse.core.internal.events.BuildManager$1.run(BuildManager.java:441)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:47)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:444)
	at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:555)
	at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:503)
	at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:585)
	at org.eclipse.core.internal.events.AutoBuildJob.doBuild(AutoBuildJob.java:207)
	at org.eclipse.core.internal.events.AutoBuildJob.run(AutoBuildJob.java:300)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

and

eclipse.buildId=4.34.0.20241128-0756
java.version=23.0.2
java.vendor=Eclipse Adoptium
BootLoader constants: OS=macosx, ARCH=aarch64, WS=cocoa, NL=en_GE
Framework arguments:  -product org.eclipse.epp.package.committers.product -keyring /Users/vasiligulevich/.eclipse_keyring
Command-line arguments:  -os macosx -ws cocoa -arch aarch64 -product org.eclipse.epp.package.committers.product -keyring /Users/vasiligulevich/.eclipse_keyring -data file:/Users/vasiligulevich/xored/rcptt/ws/pde/

org.eclipse.ajdt.ui
Error
Wed Nov 05 10:26:21 GMT+04:00 2025
Compile error: AssertionError thrown: array store with invalid types

java.lang.AssertionError: array store with invalid types
	at org.aspectj.org.eclipse.jdt.internal.compiler.codegen.OperandStack.xastore(OperandStack.java:177)
	at org.aspectj.org.eclipse.jdt.internal.compiler.codegen.CodeStream.aastore(CodeStream.java:231)
	at org.aspectj.ajdt.internal.compiler.ast.AdviceDeclaration.generateProceedMethod(AdviceDeclaration.java:246)
	at org.aspectj.ajdt.internal.compiler.ast.AdviceDeclaration.generateCode(AdviceDeclaration.java:284)
	at org.aspectj.org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.generateCode(TypeDeclaration.java:777)
	at org.aspectj.ajdt.internal.compiler.ast.AspectDeclaration.generateCode(AspectDeclaration.java:297)
	at org.aspectj.org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.generateCode(TypeDeclaration.java:875)
	at org.aspectj.org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.generateCode(CompilationUnitDeclaration.java:403)
	at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.process(Compiler.java:837)
	at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.processCompiledUnits(Compiler.java:458)
	at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:359)
	at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:310)
	at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation(AjBuildManager.java:1102)
	at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performBuild(AjBuildManager.java:276)
	at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild(AjBuildManager.java:189)
	at org.aspectj.ajde.core.internal.AjdeCoreBuildManager.performBuild(AjdeCoreBuildManager.java:105)
	at org.aspectj.ajde.core.AjCompiler.buildFresh(AjCompiler.java:100)
	at org.eclipse.ajdt.core.builder.AJBuilder.build(AJBuilder.java:251)
	at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:1077)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:47)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:296)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:352)
	at org.eclipse.core.internal.events.BuildManager$1.run(BuildManager.java:441)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:47)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:444)
	at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:555)
	at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:503)
	at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:585)
	at org.eclipse.core.internal.events.AutoBuildJob.doBuild(AutoBuildJob.java:207)
	at org.eclipse.core.internal.events.AutoBuildJob.run(AutoBuildJob.java:300)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

aclement · 2025-11-06T00:33:00Z

Those will be variants of things fixed in 1.9.25 I suspect (e.g eclipse-aspectj/aspectj#336, eclipse-aspectj/aspectj#337)

JDT no longer supports Java older than 1.8: - eclipse-jdt/eclipse.jdt.ui#1685 - eclipse-jdt/eclipse.jdt.ui#1894

See eclipse-jdt/eclipse.jdt.core#4167

basilevs · 2025-11-06T12:21:59Z

@aclement thank you. I've updated to 1.9.25 and this error went away.

My basic manual tests seem fine now, but I fail to make even minimal JUnit suite to pass.
For example, org.eclipse.ajdt.core.tests.ajde.Bug273770Tests fails consistently. It does not seem to be related to AspectJ. I'm not sure if it worked in a previous AJDT version.

basilevs · 2025-11-11T16:16:48Z

I'm not sure if it worked in a previous AJDT version.

I've confirmed same tests were failing on AspectJ 22. So this PR adds no regressions in that regard.

basilevs · 2025-11-11T16:18:33Z

@aclement @kriegaex This PR is ready for review.

basilevs · 2025-11-18T10:33:18Z

@aclement @kriegaex could you make me a committer or otherwise grant push and CI access? My goal is to publish a release usable from RCPTT builds.

aclement · 2025-11-19T00:33:52Z

 org.eclipse.team.core;bundle-version="3.8.1100",
- org.aspectj.runtime
+ org.aspectj.runtime,
+ org.eclipse.jdt.ui;bundle-version="[3.9.0,4.3.0)"


Is this extra dependency on jdt.ui required?

Without this dependency, Eclipse PDE produces "org.eclipse.jdt.internal.ui.refactoring.UserInterfaceManager cannot be resolved to a type" error for org.eclipse.ajdt.core.ReflectionUtils.executePrivateMethod(Class<T>, String, Class<?>[], UserInterfaceManager, Object[]):

ajdt/org.eclipse.ajdt.core/src/org/eclipse/ajdt/core/ReflectionUtils.java

Lines 61 to 70 in 737cd73

public static <T> Object executePrivateMethod(Class<T> clazz, String methodName, Class<?>[] types, org.eclipse.jdt.internal.ui.refactoring.UserInterfaceManager target, Object[] args) {

// forget caching for now...

try {

Method method = clazz.getDeclaredMethod(methodName, types);

method.setAccessible(true);

return method.invoke(target, args);

} catch (Exception ignored) {

}

return null;

}

The problem is not reproducible with Tycho compiler.

This explicit type is unnecessary for this method to function, so I'm reverting a part of commit where it was introduced and the additional dependency I've added to appease the compiler.

Thank you for pointing this out. I also found a new dependency in an update strange , and failed to realize that it had always been superfluous.

This partially reverts c978c11.

basilevs added 3 commits November 2, 2025 16:12

Bump AspectJ to 1.9.24

ebd80fe

This state does not compile.

Fix compilation

cd8c3cb

JDT has been updated and changed interfaces.

Do not load obsolete AspectJ components eclipse-aspectj#65

7720b46

A script to bump AspectJ version

e50f295

basilevs added 3 commits November 4, 2025 16:03

Drop support for Java 1.5 (class version 49) eclipse-aspectj#64

cc83beb

Fixes eclipse-aspectj#64. JDT no longer supports Java older than 1.8: - eclipse-jdt/eclipse.jdt.ui#1685 - eclipse-jdt/eclipse.jdt.ui#1894

Merge branch 'aspectj_1.9.24' into dropJava1.5_64

7bf7c37

Fix "org.aspectj.org.eclipse.jdt.core.JavaCore.getPlugin()" is null

25a5859

basilevs marked this pull request as draft November 5, 2025 06:26

basilevs added 4 commits November 6, 2025 09:35

Merge branch 'aspectjBumpScript' into aspectj_1.9.24

7a6b232

Bump AspectJ to 1.9.25

73a9c1f

Drop support for Java 1.5 (class version 49)

ce78117

JDT no longer supports Java older than 1.8: - eclipse-jdt/eclipse.jdt.ui#1685 - eclipse-jdt/eclipse.jdt.ui#1894

Fix compilation error

94727a4

See eclipse-jdt/eclipse.jdt.core#4167

basilevs changed the title ~~Aspectj 1.9.24~~ Aspectj 1.9.25 Nov 6, 2025

Merge branch 'dropJava1.5_64' into aspectj_1.9.24

4a5ac44

Fix PDE build

d859d02

basilevs marked this pull request as ready for review November 11, 2025 16:17

This was referenced Nov 12, 2025

Support Java 23 #66

Closed

Fix "NoSuchMethodError: is50OrHigher" #71

Closed

A script to bump AspectJ version #69

Closed

RCPTT not usable with Java 23 eclipse-rcptt/org.eclipse.rcptt#166

Closed

aclement reviewed Nov 19, 2025

View reviewed changes

Removed an unnecessary dependency.

b703fc1

This partially reverts c978c11.

basilevs requested a review from aclement November 19, 2025 18:37

aclement merged commit 5c7de2d into eclipse-aspectj:master Nov 20, 2025
4 checks passed

basilevs deleted the aspectj_1.9.24 branch November 26, 2025 11:39

basilevs mentioned this pull request Feb 11, 2026

Eclipse 2026-03 compatibility #73 #76

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Aspectj 1.9.25#70

Aspectj 1.9.25#70
aclement merged 14 commits intoeclipse-aspectj:masterfrom
basilevs:aspectj_1.9.24

basilevs commented Nov 3, 2025 •

edited

Loading

Uh oh!

basilevs commented Nov 3, 2025 •

edited

Loading

Uh oh!

kriegaex commented Nov 4, 2025

Uh oh!

basilevs commented Nov 5, 2025

Uh oh!

aclement commented Nov 6, 2025

Uh oh!

basilevs commented Nov 6, 2025 •

edited

Loading

Uh oh!

basilevs commented Nov 11, 2025 •

edited

Loading

Uh oh!

basilevs commented Nov 11, 2025

Uh oh!

basilevs commented Nov 18, 2025 •

edited

Loading

Uh oh!

aclement Nov 19, 2025

Uh oh!

basilevs Nov 19, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	public static <T> Object executePrivateMethod(Class<T> clazz, String methodName, Class<?>[] types, org.eclipse.jdt.internal.ui.refactoring.UserInterfaceManager target, Object[] args) {
	// forget caching for now...
	try {
	Method method = clazz.getDeclaredMethod(methodName, types);
	method.setAccessible(true);
	return method.invoke(target, args);
	} catch (Exception ignored) {
	}
	return null;
	}

Conversation

basilevs commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

basilevs commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kriegaex commented Nov 4, 2025

Uh oh!

basilevs commented Nov 5, 2025

Uh oh!

aclement commented Nov 6, 2025

Uh oh!

basilevs commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

basilevs commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

basilevs commented Nov 11, 2025

Uh oh!

basilevs commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aclement Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

basilevs Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

basilevs commented Nov 3, 2025 •

edited

Loading

basilevs commented Nov 3, 2025 •

edited

Loading

basilevs commented Nov 6, 2025 •

edited

Loading

basilevs commented Nov 11, 2025 •

edited

Loading

basilevs commented Nov 18, 2025 •

edited

Loading

basilevs Nov 19, 2025 •

edited

Loading