Skip to content

iox-#2518: Fix invalid maintainer string#2519

Open
mjcarroll wants to merge 1 commit intoeclipse-iceoryx:mainfrom
mjcarroll:mjcarroll/fix_maintainer
Open

iox-#2518: Fix invalid maintainer string#2519
mjcarroll wants to merge 1 commit intoeclipse-iceoryx:mainfrom
mjcarroll:mjcarroll/fix_maintainer

Conversation

@mjcarroll
Copy link
Copy Markdown

@mjcarroll mjcarroll commented Apr 29, 2026

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.87%. Comparing base (9e61a61) to head (9d00153).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2519   +/-   ##
=======================================
  Coverage   77.87%   77.87%           
=======================================
  Files         446      446           
  Lines       16301    16301           
  Branches     2320     2320           
=======================================
  Hits        12694    12694           
  Misses       2759     2759           
  Partials      848      848           
Flag Coverage Δ
unittests 77.70% <ø> (ø)
unittests_timing 15.01% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elBoberido
Copy link
Copy Markdown
Member

@mjcarroll thanks for bringing this up. Did you already sign the ECA?

If this is a problem for you, I could also adjust the string but there is no hurry if you need more time.

@mjcarroll
Copy link
Copy Markdown
Author

We went ahead and patched it in the debian packages we generated for the lyrical release, so getting it fixed upstream is less critical at the moment. I think that I signed off with the wrong email address that I didn't have the ECA associated with. I'll get that fixed.

@elBoberido
Copy link
Copy Markdown
Member

@mjcarroll okay, I will then backport this to the release_2.0 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Malformed contact for maintainer Eclipse Foundation, Inc. in package.xml

2 participants