You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.59%. Comparing base (13a8f4e) to head (c936f2a). ⚠️ Report is 11 commits behind head on main.
@elfenpiff since this is now already on main via another PR, shall the name or the error enum value be changed to InterruptedBySinal or shall we keep it as is and just close this PR and the issue?
@elfenpiff since this is now already on main via another PR, shall the name or the error enum value be changed to InterruptedBySinal or shall we keep it as is and just close this PR and the issue?
Nope, we should rename it in the whole code base to InterruptedBySignal and also all error messages need to be adjusted so that they state operation X was interrupted by a signal ... currently they state that they an interrupt signal was raised but actually this is wrong, it could be any kind of signal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
Pre-Review Checklist for the PR Author
Convert to draft)iox2-123-introduce-posix-ipc-example)[#123] Add posix ipc example)PR Reviewer Reminders
References
Closes #1556