Skip to content

[WIP] [DO NOT REVIEW] [#1556] Propagate 'InterruptedBySinal' errors up in the stack as distinct error#1557

Open
elBoberido wants to merge 1 commit into
eclipse-iceoryx:mainfrom
ekxide:iox2-1556-propagate-interrupted-by-signal-error-up-in-the-stack
Open

[WIP] [DO NOT REVIEW] [#1556] Propagate 'InterruptedBySinal' errors up in the stack as distinct error#1557
elBoberido wants to merge 1 commit into
eclipse-iceoryx:mainfrom
ekxide:iox2-1556-propagate-interrupted-by-signal-error-up-in-the-stack

Conversation

@elBoberido

@elBoberido elBoberido commented Apr 15, 2026

Copy link
Copy Markdown
Member

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
    • Commit messages have the issue ID ([#123] Add posix ipc example)
    • Keep in mind to use the same email that was used to sign the Eclipse Contributor Agreement
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API breaking changes

PR Reviewer Reminders

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

References

Closes #1556

@elBoberido
elBoberido force-pushed the iox2-1556-propagate-interrupted-by-signal-error-up-in-the-stack branch from 9bf1412 to c936f2a Compare April 15, 2026 20:12
@codecov

codecov Bot commented Apr 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.59%. Comparing base (13a8f4e) to head (c936f2a).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
iceoryx2-cxx/include/iox2/enum_translation.hpp 0.00% 6 Missing ⚠️
iceoryx2-cal/src/zero_copy_connection/common.rs 0.00% 4 Missing ⚠️
iceoryx2/src/port/details/sender.rs 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1557      +/-   ##
==========================================
- Coverage   77.65%   77.59%   -0.06%     
==========================================
  Files         418      418              
  Lines       39601    39659      +58     
  Branches     1285     1285              
==========================================
+ Hits        30751    30774      +23     
- Misses       7806     7841      +35     
  Partials     1044     1044              
Flag Coverage Δ
CPP 67.13% <0.00%> (-0.06%) ⬇️
Rust 77.46% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
iceoryx2-cal/src/zero_copy_connection/mod.rs 73.14% <ø> (ø)
iceoryx2/src/port/mod.rs 28.57% <ø> (ø)
iceoryx2/src/port/details/sender.rs 82.80% <0.00%> (-0.54%) ⬇️
iceoryx2-cal/src/zero_copy_connection/common.rs 91.22% <0.00%> (-0.40%) ⬇️
iceoryx2-cxx/include/iox2/enum_translation.hpp 47.62% <0.00%> (-0.23%) ⬇️

... and 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elBoberido

Copy link
Copy Markdown
Member Author

@elfenpiff since this is now already on main via another PR, shall the name or the error enum value be changed to InterruptedBySinal or shall we keep it as is and just close this PR and the issue?

@elfenpiff

Copy link
Copy Markdown
Contributor

@elfenpiff since this is now already on main via another PR, shall the name or the error enum value be changed to InterruptedBySinal or shall we keep it as is and just close this PR and the issue?

Nope, we should rename it in the whole code base to InterruptedBySignal and also all error messages need to be adjusted so that they state operation X was interrupted by a signal ... currently they state that they an interrupt signal was raised but actually this is wrong, it could be any kind of signal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Propagate 'EINTR' errnos as distinct errors to the user instead of hiding them in a generic 'InternalError'

2 participants