[#1745] refine flatbuffer api#1827
Merged
elfenpiff merged 26 commits intoJul 22, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1827 +/- ##
==========================================
- Coverage 76.28% 76.12% -0.16%
==========================================
Files 441 443 +2
Lines 44030 44263 +233
Branches 1356 1356
==========================================
+ Hits 33587 33695 +108
- Misses 9324 9449 +125
Partials 1119 1119
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
elfenpiff
force-pushed
the
iox2-1745-refine-flatbuffer-api
branch
3 times, most recently
from
July 20, 2026 08:13
b69ff60 to
2b402e6
Compare
| > Builder<Payload, UserHeader, ServiceType> | ||
| { | ||
| fn has_flatbuffer_payload() -> bool { | ||
| use iceoryx2_bb_elementary_traits::type_name::TypeName; |
Contributor
There was a problem hiding this comment.
Can the as ... two lines below be removed now?
dkroenke
reviewed
Jul 21, 2026
Comment on lines
+185
to
+187
| !(position < (self.start.as_ptr() as usize) | ||
| || position > (self.start.as_ptr() as usize) + self.size | ||
| || !(position - self.start.as_ptr() as usize).is_multiple_of(self.bucket_size)), |
Contributor
There was a problem hiding this comment.
It would be clearer if you define self.start.as_ptr() as usize outside the debug_assert.
Contributor
Author
There was a problem hiding this comment.
I know but the stuff inside the debug assert is optimized away when the debug assertions are disabled.
Contributor
There was a problem hiding this comment.
True, but you do the same with position... Up to you.
FerdinandSpitzschnueffler
approved these changes
Jul 22, 2026
FerdinandSpitzschnueffler
left a comment
FerdinandSpitzschnueffler
left a comment
Contributor
There was a problem hiding this comment.
Only some nitpicks that can be addressed in the follow-up PR.
Comment on lines
+222
to
223
| /// * the pointer must be acquired with [`SharedMemory::allocate()`] - extracted from the | ||
| /// [`ShmPointer`] |
Contributor
There was a problem hiding this comment.
Suggested change
| /// * the pointer must be acquired with [`SharedMemory::allocate()`] - extracted from the | |
| /// [`ShmPointer`] | |
| /// * the pointer must be acquired with [`SharedMemory::allocate()`] |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
This is an intermediate PR. Some flatbuffer related functionality is not yet tested.
loan_flatbuffer()instead ofloan_uninit()(not yet functional)ShmPointerfor shm allocators, required for flatbuffer allocator)PointerTraitrenamed toPointerGenericPointerrenamed toPointerFamily, allGeneric**Ptrrenamed to**PtrFamilyAllocatorreturnsPointer<u8>instead ofPointer<[u8]>when acquiring memoryPre-Review Checklist for the PR Author
Convert to draft)iox2-123-introduce-posix-ipc-example)[#123] Add posix ipc example)PR Reviewer Reminders
References
Relates to #1745