Replace Thread.sleep() with proper synchronization in tests#1773
Open
fbricon wants to merge 1 commit intoeclipse-lemminx:mainfrom
Open
Replace Thread.sleep() with proper synchronization in tests#1773fbricon wants to merge 1 commit intoeclipse-lemminx:mainfrom
fbricon wants to merge 1 commit intoeclipse-lemminx:mainfrom
Conversation
Tests were using Thread.sleep() (up to 5 seconds each) to wait for async operations like resource downloads and validation triggers, making the test suite unnecessarily slow (~71s test time). Key changes: - BaseFileTempTest: replace sleep(1050) with Files.setLastModifiedTime() to ensure filesystem change detection without waiting - XMLLanguageService: return download futures from publishDiagnostics() so tests can await them directly - XMLAssert: add awaitDownloads() helper, remove retrigger callback - MockXMLLanguageClient: add waitForDiagnosticCount() polling helper - Replace all 5-second HACK sleeps with awaitDownloads() - Replace async validation sleeps with waitForDiagnosticCount() - DocumentLifecycleParticipantTest: poll for lifecycle callback completion - CacheResourcesManagerTest: reduce cache TTL from 1s to 100ms Build time reduced from ~1m17s to ~15s (5x faster). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
@fbricon this PR looks very good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests were using Thread.sleep() (up to 5 seconds each) to wait for
async operations like resource downloads and validation triggers,
making the test suite unnecessarily slow (~71s test time).
Key changes:
to ensure filesystem change detection without waiting
so tests can await them directly
Build time reduced from ~1m17s to ~15s (5x faster).
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com