aio: Fix setting adc bits when initializing#1103
aio: Fix setting adc bits when initializing#1103AsuraZeng wants to merge 1 commit intoeclipse-mraa:masterfrom
Conversation
jan-kiszka
left a comment
There was a problem hiding this comment.
The fix appear correct to me, but you should rework the commit message: set the number of bits to those that the hardware reports - rather than hard-coded 10 bits.
Also, DEFAULT_BITS seems unused now.
7bc183c to
e523a2b
Compare
Use the number of adc bits set by the hardware instead of using the default hard-coded 10 bits Signed-off-by: chao zeng <chao.zeng@siemens.com>
e523a2b to
d03c75e
Compare
yes, remove the |
|
On second look, the situation looks less clear to me again: |
|
None-issue, see siemens/meta-iot2050#407. MRAA chose to start AIO pins with a hardware-independent number bit of bits, even if the hardware can do more. Nothing to do here. |
Set the adc bits to the default value of 10,
so the raw bits of the platform will not take
effect during initialization, and it is always the default value
Signed-off-by: chao zeng chao.zeng@siemens.com