Skip to content

Add additional-metadata option to interpolate action#259

Open
pgeier wants to merge 1 commit intodevelopfrom
feature/interpolate-additional-metadata
Open

Add additional-metadata option to interpolate action#259
pgeier wants to merge 1 commit intodevelopfrom
feature/interpolate-additional-metadata

Conversation

@pgeier
Copy link
Copy Markdown
Contributor

@pgeier pgeier commented Apr 13, 2026

Description

To enable HEALPix interplation in the ClimateDT plans, the output metadata of the interpolate action should have a modified "resolution" key word. To allow overwriting/adding metadata, an additional option is required. This option is named "additional-metadata" and behaves similar to the option in the legacy encoder.

In previous versions this modification has been taken place in the legacy encode action.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/multio/pull-requests/PR-259

@pgeier pgeier force-pushed the feature/interpolate-additional-metadata branch from b620211 to ef4307c Compare April 13, 2026 08:39
@pgeier pgeier force-pushed the feature/interpolate-additional-metadata branch from b4bedca to 736a80a Compare April 13, 2026 08:50
@pgeier pgeier marked this pull request as ready for review April 13, 2026 08:54
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.29%. Comparing base (6178fe7) to head (736a80a).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #259   +/-   ##
========================================
  Coverage    56.28%   56.29%           
========================================
  Files          321      320    -1     
  Lines        21188    21195    +7     
  Branches      1688     1686    -2     
========================================
+ Hits         11925    11931    +6     
- Misses        9263     9264    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MircoValentiniECMWF
Copy link
Copy Markdown
Collaborator

I think that adding a passthrough mechanism to inject everything is not ok.
If we need to inject resolution we should add a n option to inject the resolution, or at least we should filter the "additionalMetadata"

@stefaniereuter
Copy link
Copy Markdown
Contributor

@MircoValentiniECMWF I don't have a strong opinion either way. the additional metadata would be consistent with the approach that we have in the statistic mtg2 action and the way we have done it before:

new: https://git.ecmwf.int/users/ecm4053/repos/multio_plans/pull-requests/2/commits/bd164fb4be96ae592f6887d70d5bccf827b81b6c#climate-dt%2Fatmosphere%2F1_1_Hourly_HEALpix_high.yaml

old: https://git.ecmwf.int/projects/DE/repos/raps/browse/multio_yaml/multio-fesom.yaml?at=0.1.17#98

Is there a different reason, why you would like to add this additional protection layer? I'm okay to add the option resolution but I'm a bit worried that people think this would actually change something in the interpolate action and not just add metadata based on the before defined options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants