Add additional-metadata option to interpolate action#259
Add additional-metadata option to interpolate action#259
Conversation
b620211 to
ef4307c
Compare
b4bedca to
736a80a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #259 +/- ##
========================================
Coverage 56.28% 56.29%
========================================
Files 321 320 -1
Lines 21188 21195 +7
Branches 1688 1686 -2
========================================
+ Hits 11925 11931 +6
- Misses 9263 9264 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think that adding a passthrough mechanism to inject everything is not ok. |
|
@MircoValentiniECMWF I don't have a strong opinion either way. the additional metadata would be consistent with the approach that we have in the statistic mtg2 action and the way we have done it before: old: https://git.ecmwf.int/projects/DE/repos/raps/browse/multio_yaml/multio-fesom.yaml?at=0.1.17#98 Is there a different reason, why you would like to add this additional protection layer? I'm okay to add the option resolution but I'm a bit worried that people think this would actually change something in the interpolate action and not just add metadata based on the before defined options. |
Description
To enable HEALPix interplation in the ClimateDT plans, the output metadata of the interpolate action should have a modified "resolution" key word. To allow overwriting/adding metadata, an additional option is required. This option is named "additional-metadata" and behaves similar to the option in the legacy encoder.
In previous versions this modification has been taken place in the legacy encode action.
Contributor Declaration
By opening this pull request, I affirm the following:
🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/multio/pull-requests/PR-259