Conversation
iago-lito
force-pushed
the
boost
branch
15 times, most recently
from
9939c53 to
5510cf7
Compare
iago-lito
force-pushed
the
boost
branch
2 times, most recently
from
5746728 to
d956c15
Compare
iago-lito
force-pushed
the
boost
branch
5 times, most recently
from
9e185e9 to
f5caa74
Compare
Take this opportunity to get rid of complicated `@get`, `@ref`, `@set` accesses.
These extension points could make a better story for components factorization. Do continue exploiting the ones sketched in `network_config`. This may even eventually predate `GraphDataInputs.jl`: all this glue code between the internals and components specifications need __simplification__!
Much more flesh in these `NetworkConfig` dispatchers, they might prove much useful. GraphDataInputs is getting mostly unneeded. Also maybe the *framework components macros* if they keep being only called from within generic functions like this.
There is no loss of generality and it'll simplify components specifications.
.. as we refactor down to the first three checked components. Simpler organization I hope: rely much on the dispatchers for any component special behaviour. Checks are bound to their typical component type, here NodeData.
Harmonize dispatchers naming, picking `d` variable whatever it is, and `DT` for its type. Fix world count blocker to aliasing for writeable properties.
.. while I was 🛡️ Testing typical NodeField component, resume later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Into rewriting the internals so as to address long-standing #141.