Skip to content

refine overridable functions when using module Base. #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nanne007 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Open

refine overridable functions when using module Base. #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/httpoison/base.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,16 @@ defmodule HTTPoison.Base do

defp process_status_code(status_code), do: status_code

defoverridable [
process_url: 1,
process_request_body: 1,
process_response_body: 1,
process_request_headers: 1,
process_response_chunk: 1,
process_headers: 1,
process_status_code: 1
]

@doc false
@spec transformer(pid) :: :ok
def transformer(target) do
Expand Down Expand Up @@ -327,7 +337,6 @@ defmodule HTTPoison.Base do
@spec options!(binary, headers, Keyword.t) :: Response.t | AsyncResponse.t
def options!(url, headers \\ [], options \\ []), do: request!(:options, url, "", headers, options)

defoverridable Module.definitions_in(__MODULE__)
end
end

Expand Down