Skip to content

Don't use require in ESM, use dynamic import - #205

Open
segevfiner wants to merge 2 commits into
egoist:masterfrom
swimmio:no-require-in-esm
Open

Don't use require in ESM, use dynamic import#205
segevfiner wants to merge 2 commits into
egoist:masterfrom
swimmio:no-require-in-esm

Conversation

@segevfiner

Copy link
Copy Markdown

Fixes #168

@talkor

talkor commented Aug 30, 2022

Copy link
Copy Markdown

Thank you for this!

@edenhermelin

Copy link
Copy Markdown

@segevfiner thank you so much for this, it helps us a lot!
@egoist - looks like the CI build fails for linter (on the dynamic import). Any chance you can look into it please? this fix will make this library be usable by Vite 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error with Vite

3 participants