Fix warnings for VC builds and wStringBuffer's length#13
Open
kagnusdev wants to merge 181 commits intoeinstein95:masterfrom
Open
Fix warnings for VC builds and wStringBuffer's length#13kagnusdev wants to merge 181 commits intoeinstein95:masterfrom
kagnusdev wants to merge 181 commits intoeinstein95:masterfrom
Conversation
From pokecrystal: - 0425018d1ce5b3b726e3cd83f59f14ead9171c92 - 8b429e2a545e87407a3b8c7b92f7ceafc455e390
* Add table assertion to `TrainerDataPointers` * Add table assertion to `TrainerNamePointers`
This introduces `def_script_pointers`, `def_text_pointers`, and `object_const_def` macros, and applies them to all maps. Most other map labels have also been identified.
Co-authored-by: mid-kid <esteve.varela@gmail.com>
* Add constants for wMapConnections bits * Apply Vulcandth and Rangi42 feedback --------- Co-authored-by: vulcandth <vulcandth@gmail.com>
* Added newer decomp projects to readme * Lowercase pret * Replaced decomp list with pret.github.io link * Align readme with pokecrystal --------- Co-authored-by: vulcandth <vulcandth@gmail.com>
Resolves #411 Co-Authored-By: SnDream <12762219+sndream@users.noreply.github.com>
`TilePairCollisionsWater` contains the entry `db CAVERN, $14, $05`, which prevents surfing from raised cave ground tiles. If `wTilePlayerStandingOn` is not updated when the start menu is opened, it will be left at the previous tile, which will be the raised ground tile if you have just walked onto the stairs from one.
The `--ignore` flag is not needed in Gen 1
- Use `OBJ_SIZE` and `TILE_SIZE` from hardware.inc. - `SPRITESTATEDATA1_LENGTH`, `NUM_SPRITESTATEDATA_STRUCTS` and `TILE_1BPP_SIZE` are used in some places. - Highlight an oversight in `OakSpeech` where several direct MBC bank switches are requested. - Remove redundant comments in home/overworld.asm. - Add unreferenced `FillBgMap` function to avoid a byte of dead code. - Some constants added in wram.asm. - Correctly separate the commented code in `SaveMainData`.
…name them to "toggleable objects" (#557)
… "hidden events" (#559)
Add comments explaining the redundant move grammar categories inherited from the Japanese version.
Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the warnings that appear when building the VC versions. It also fixes wStringBuffer's length.
I merged directly from pret/pokered's master but it looks like the previous synchronizations were made by cherry picking so this branch contains the original commits whose changes were already applied. If this is a problem, I'll remove them.