Move latest major version parsing into versions#2131
Closed
Copilot wants to merge 3 commits into
Closed
Conversation
Copilot
AI
changed the title
[WIP] Fix code according to review comment
Move latest major version parsing into May 29, 2026
versions
Member
|
@copilot which comment triggered this PR to be raised? I cant see a connection |
Contributor
Author
I couldn’t find a specific visible review comment on this PR that directly triggered it. This follow-up was intended to address earlier feedback about centralizing the major-version parsing in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the review feedback to centralize distribution major-version parsing in
esrally.utils.versionsrather than keeping ad hoc parsing in the provisioner. The change also adds focused coverage for the extracted helper.Extract version parsing helper
latest_supported_major(version)toesrally.utils.versions.serverless.Version.from_string(...).majorfor versioned distributions.Align provisioner with shared logic
ElasticsearchInstalleron the sharedversionsAPI instead of local parsing logic.Add focused coverage
serverless