fix: Add CORS headers to error responses for CM origins#114
Merged
Conversation
When an error occurs, the error handler now ensures CORS headers are set for Commerce Manager origins. This prevents CORS errors from masking the actual error (e.g., auth failures appearing as CORS blocked). Previously, if a request from CM failed with an error, the browser would show a CORS error because the error response lacked Access-Control headers. Now the actual error status and message will be visible in the browser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When credentials are included in a request and the server returns an error without CORS headers, browsers block reading the response entirely. This causes auth errors (401, 403) to appear as CORS errors, making debugging difficult.
Solution
In the error handler (
addEndErrorHandlers), check if the request origin is an allowed CM origin and set the appropriate CORS headers before sending the error response.Test plan