Skip to content

Try using Danger with the Node/Docker fix? - #6079

Merged
pixlwave merged 2 commits into
developfrom
doug/danger
Aug 27, 2026
Merged

Try using Danger with the Node/Docker fix?#6079
pixlwave merged 2 commits into
developfrom
doug/danger

Conversation

@pixlwave

@pixlwave pixlwave commented Aug 27, 2026

Copy link
Copy Markdown
Member

Uses the merge commit for danger/swift#667

Additionally puts back the permissions to write PR comments and statuses.

@pixlwave
pixlwave requested a review from a team as a code owner August 27, 2026 10:50
@pixlwave
pixlwave requested review from stefanceriu and removed request for a team August 27, 2026 10:50
@pixlwave pixlwave added the pr-build for changes related to build, tools, CI/CD label Aug 27, 2026

- name: Danger
uses: danger/swift@434d7c25f3b02d490a340b23f5e78dd15a5670bc # 3.22.1
uses: danger/swift@751aa740b2bd69ea1b54444a945961e64c38fc22 # 3.22.1

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional to pull in a working version until another release is made.

@pixlwave
pixlwave force-pushed the doug/danger branch 3 times, most recently from a29b782 to 38ec436 Compare August 27, 2026 11:25
@pixlwave pixlwave changed the title Try using Danger with the Node/Docker fix? Fixes #1234 (test): Try using Danger with the Node/Docker fix? Aug 27, 2026
@pixlwave pixlwave changed the title Fixes #1234 (test): Try using Danger with the Node/Docker fix? Try using Danger with the Node/Docker fix? Aug 27, 2026
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.88%. Comparing base (8874ee1) to head (849a53e).
⚠️ Report is 2 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6079      +/-   ##
===========================================
- Coverage    74.89%   74.88%   -0.02%     
===========================================
  Files          829      829              
  Lines        58745    58758      +13     
===========================================
+ Hits         43996    43998       +2     
- Misses       14749    14760      +11     
Flag Coverage Δ
unittests 65.35% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@pixlwave
pixlwave merged commit 2b9ec03 into develop Aug 27, 2026
15 of 17 checks passed
@pixlwave
pixlwave deleted the doug/danger branch August 27, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-build for changes related to build, tools, CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants