Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/wallaby/session_store.ex
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ defmodule Wallaby.SessionStore do

case result do
[{ref, pid}] ->
true = Process.demonitor(ref)
true = Process.demonitor(ref, [:flush])
:ets.delete(state.ets_table, {ref, session.id, pid})

[] ->
Expand Down
38 changes: 38 additions & 0 deletions test/wallaby/session_store_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,44 @@ defmodule Wallaby.SessionStoreTest do
refute Enum.member?(store, second)
assert Enum.member?(store, third)
end

test "flushes DOWN message when demonitoring", %{session_store: session_store, table: table} do
session = %Session{id: "session_to_flush"}

test_pid = self()

owner_pid =
spawn(fn ->
:ok = SessionStore.monitor(session_store, session)
send(test_pid, :monitored)
receive do: (_ -> :ok)
end)

receive do
:monitored -> :ok
after
1000 -> flunk("Failed to monitor session")
end

# Suspend SessionStore so we can queue messages
:sys.suspend(session_store)

# We spawn a task because GenServer.call will block until SessionStore resumes
Task.async(fn ->
SessionStore.demonitor(session_store, session)
end)

Process.sleep(50)
Process.exit(owner_pid, :kill)
Process.sleep(50)
:sys.resume(session_store)

# Ensure all messages are processed (including potentially fatal DOWN)
:sys.get_state(session_store)

# Check if SessionStore is still working
assert [] == SessionStore.list_sessions_for(name: table)
end
end

test "removes sessions when the monitored process dies", %{
Expand Down
Loading