Migrate Italian and Polish to LibreOffice sources - #6
Merged
Conversation
Each .sed patch file now leads with a comment describing the class of problem it addresses — the harm path that justifies the patch — rather than the specific instance that motivated it. Also generalize the Italian apostrophe ICONV patch to anchor on the normalized SET UTF-8 line instead of a source-specific #Nota comment. The original anchor only matched the (now offline) PLIO source; this one survives any future upstream that produces a SET line, which the crawl pipeline always normalizes.
Italian (it): the previous source (PLIO via SourceForge OXT) has been offline for years and the crawl entry was commented out, so the shipped dictionary was a multi-year-old frozen file. Re-enable the language using LibreOffice's it_IT, which is the actively maintained Italian Hunspell dictionary by LibreItalia (Marina Latini), license GPL-3.0. Polish (pl): the previous source (OpenOffice extension on a SourceForge mirror, 2017-era) has been superseded by the LibreOffice-bundled pl_PL build maintained from sjp.pl — ~16% larger vocabulary, license unchanged. Both languages now share the existing libreoffice crawl entry that we already use for de, ru, pt and sv. The standalone crawl "polish" entry is removed since nothing references it anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #5 — depends on the patches mechanism from that PR.
Summary
Patch documentation cleanup
Each `.sed` patch file now leads with a comment describing the class of problem it addresses, not the specific instance that motivated it. The Italian apostrophe-ICONV patch is also re-anchored on the normalized `SET UTF-8` line so it survives any future Italian upstream the pipeline normalizes through `iconv`.
Languages considered but not migrated
When I actually pulled side-by-side dictionary content from LibreOffice for the other "orphan-ish" languages, the picture changed:
Skipped those: a same-content URL move without a real upstream quality argument isn't worth the churn.