Closed
Conversation
elsirion
reviewed
Jan 21, 2026
| port: u16, | ||
|
|
||
| #[arg(short = 'H', long, env = "BLITZID_HOST", default_value = "127.0.0.1")] | ||
| #[arg(short = 'H', long, env = "BLITZID_HOST", default_value = "0.0.0.0")] |
Owner
There was a problem hiding this comment.
Generally it's not recommended to bind to 0.0.0.0 by default since users may not be aware they are exposing the service to the world. With docker that's different, you still have to be explicit about it. I changed the way we build the docker file to set the default bind address to 0.0.0.0 in the container 9230335
Owner
There was a problem hiding this comment.
But I also noticed the container is way too large, investigating, we probably ship the rust toolchain by accident or something similar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change the default host to 0.0.0.0 to make it easier to forward port without setting env variable for host running docker.