embassy-usb-driver: remove dependency on embedded-io-async#5589
Open
yodaldevoid wants to merge 1 commit intoembassy-rs:mainfrom
Open
embassy-usb-driver: remove dependency on embedded-io-async#5589yodaldevoid wants to merge 1 commit intoembassy-rs:mainfrom
embedded-io-async#5589yodaldevoid wants to merge 1 commit intoembassy-rs:mainfrom
Conversation
`EndpointError` is no longer being used as the error type for any `embedded-io-async` impls in `embedded-usb` which was the original reason for the dependency. It has been previously expressed that we would like to remove this dependency so that `embassy-usb-driver` doesn't need to be released each time `embedded-io-async` updates.
Member
|
The point of not depending on embedded-io is to avoid breaking changes, but removing it is also a breaking change. This is why I left it as a TODO. We should leave it there until we have an actual reason to make a breaking change(e.g. an actual design deficiency in the traits that can't be fixed backwards-compatibly) and release 0.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EndpointErroris no longer being used as the error type for anyembedded-io-asyncimpls inembedded-usbwhich was the original reason for the dependency. It has been previously expressed that we would like to remove this dependency so thatembassy-usb-driverdoesn't need to be released each timeembedded-io-asyncupdates.