Property attributes are enclosed in single underscores instead of dou…#48
Open
CisterMoke wants to merge 1 commit intoemehrkay:masterfrom
Open
Property attributes are enclosed in single underscores instead of dou…#48CisterMoke wants to merge 1 commit intoemehrkay:masterfrom
CisterMoke wants to merge 1 commit intoemehrkay:masterfrom
Conversation
Owner
|
This is a great catch. Thank you for doing the work and the PR. It changes the API, so it may warrant a major version bump. I will do the work of repackaging things and adding better documentation so that upgrading is as easy as possible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the
__getattr__definition inPypherto fix issue #47.Properties are now recognized as attributes enclosed by single underscores instead of double underscored to avoid any interference with the Python subroutines