Fix: TextFormat::valign not applied correctly with custom line_height#8030
Open
rustbasic wants to merge 1 commit intoemilk:mainfrom
Open
Fix: TextFormat::valign not applied correctly with custom line_height#8030rustbasic wants to merge 1 commit intoemilk:mainfrom
rustbasic wants to merge 1 commit intoemilk:mainfrom
Conversation
Refactor vertical alignment calculation for glyph positioning.
|
Preview available at https://egui-pr-preview.github.io/pr/8030-patch177 View snapshot changes at kitdiff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: TextFormat::valign not applied correctly with custom line_height
This PR resolves an issue where
TextFormat::valign(vertical alignment) was not correctly applied whenTextFormat::line_heightwas explicitly set, especially when it matched themax_row_height.Problem:
The vertical positioning logic in
galley_from_rows()calculatedvalignbased on the difference(max_row_height - glyph.line_height). Whenglyph.line_heightwas explicitly set to a larger value (e.g.,row_height + 6.0) and became themax_row_heightfor the row, this difference became zero. As a result,valignhad no effect, and glyphs consistently appeared top-aligned within the allocated line space.Solution:
The
valigncalculation is now updated to useglyph.font_face_heightinstead ofglyph.line_height. This correctly applies vertical alignment to the glyph's actual visual content within themax_row_height, ensuringAlign::CenterandAlign::Max(Bottom) settings function as intended for customized line heights.