Fix ScrollArea::scroll_to_* calls when stick_to_bottom is Active#8033
Open
AmmarAbouZor wants to merge 1 commit intoemilk:mainfrom
Open
Fix ScrollArea::scroll_to_* calls when stick_to_bottom is Active#8033AmmarAbouZor wants to merge 1 commit intoemilk:mainfrom
ScrollArea::scroll_to_* calls when stick_to_bottom is Active#8033AmmarAbouZor wants to merge 1 commit intoemilk:mainfrom
Conversation
|
Preview is being built... Preview will be available at https://egui-pr-preview.github.io/pr/8033-fix-scroll-with-stick View snapshot changes at kitdiff |
* Fix when `ScrollArea::stick_to_bottom` is enabled and the viewport is at the last item, `ui.scroll_to_*` calls can be ignored. * Fix by treating the final per-axis explicit scroll delta as higher priority than sticky-end snapping for that frame. * Add a regression test to ensure this edge case is still covered.
AmmarAbouZor
force-pushed
the
fix-scroll-with-stick
branch
from
7810184 to
60f218f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scroll_to_*Calls are Ignored when Stick to Bottom is active #8032It includes:
ScrollAreawhenscroll_to_*could be ignored whenstick_to_bottom(true)was active and the viewport was already stuck to the bottom.The code snippets form the original issue can be used for testing here as well