Log localStorage write failures in local_storage_set#8062
Open
rustbasic wants to merge 2 commits intoemilk:mainfrom
Open
Log localStorage write failures in local_storage_set#8062rustbasic wants to merge 2 commits intoemilk:mainfrom
localStorage write failures in local_storage_set#8062rustbasic wants to merge 2 commits intoemilk:mainfrom
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/8062-patch179 View snapshot changes at kitdiff |
emilk
approved these changes
Apr 6, 2026
| match local_storage() { | ||
| Some(storage) => { | ||
| if let Err(err) = storage.set_item(key, value) { | ||
| log::info!("local_storage_set failed: key={key}, err={err:?}"); |
Owner
There was a problem hiding this comment.
Suggested change
| log::info!("local_storage_set failed: key={key}, err={err:?}"); | |
| log::warn!("local_storage_set failed: key={key}, err={err}"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log
localStoragewrite failures inlocal_storage_setDescription
This PR improves
local_storage_set()logging ineframe/src/web/storage.rs.It logs:
This helps diagnose web persistence issues such as
QuotaExceededErrorwhenlocalStorage.setItem()fails.