(FIX TO "INVALID MODEL") Convert model names to lowercase in Ai.qml #3183
Open
XChaosSaMa wants to merge 3 commits intoend-4:mainfrom
Open
(FIX TO "INVALID MODEL") Convert model names to lowercase in Ai.qml #3183XChaosSaMa wants to merge 3 commits intoend-4:mainfrom
XChaosSaMa wants to merge 3 commits intoend-4:mainfrom
Conversation
Fix Ollama model validation by applying safeModelName normalization and lowercasing consistently when both storing and looking up model keys, so that models with colons (e.g. phi4:latest) or mixed-case names (e.g. Qwen3-Coder-30B) are correctly recognized instead of throwing 'Invalid model'.
Owner
|
Thanks. Why not add the lowercasing to |
Author
|
XD, you are right. I should have put it there from the start, I'll update the PR |
Owner
|
wait why undo the setModel part |
Owner
|
i think it's fine to leave the normalization there |
Author
|
My bad, i used the last file and forgot to change it back, it's fixed now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Ollama model validation by applying safeModelName normalization and lowercasing consistently when both storing and looking up model keys, so that models with colons (e.g. phi4:latest) or mixed-case names (e.g. Qwen3-Coder-30B) are correctly recognized instead of throwing 'Invalid model'.