Elders: Hide balloon from dialogue#2365
Merged
Merged
Conversation
I have just noticed that the balloon script adds itself to the context that is available to dialogue. This means there is a cleaner way to hide the dialogue balloon before showing the storybook than what I implemented in commit dfa9e69: call `balloon.hide()` directly from the dialogue, right before calling `show_storybook()` on the Elder (which talk_behavior.gd passes as context). Implement this. Remove the plumbing that I added to make the balloon node accessible from the elder script.
|
Test build no longer available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elders: Hide balloon from dialogue
I have just noticed that the balloon script adds itself to the context
that is available to dialogue. This means there is a cleaner way to hide
the dialogue balloon before showing the storybook than what I
implemented in commit dfa9e69: call
balloon.hide()directly from the dialogue, right before callingshow_storybook()on the Elder (which talk_behavior.gd passes ascontext).
Implement this. Remove the plumbing that I added to make the balloon
node accessible from the elder script.