Update StoryBook layout#2375
Open
manuq wants to merge 2 commits into
Open
Conversation
Similar to the pause overlay. Use the same ColorRect for the background transparency instead of a Panel node.
Add a bottom row similar to the pause overlay. Use next-tab and previous-tab input actions for switching pages. Change the _input() function to _unhandled_input(). Move all inside PanelContainer, which have hardcoded positions, 64 pixels vertically. To adjust to the new row.
Collaborator
Author
|
I couldn't make it use a TabContainer yet, but this is a step toward that. |
|
Play this branch at https://play.threadbare.game/branches/endlessm/storybook-style/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the StoryBook scene a CanvasLayer.
Similar to the pause overlay. Use the same ColorRect for the background
transparency instead of a Panel node.
Replace left/right buttons with input helpers.
Add a bottom row similar to the pause overlay. Use next-tab and previous-tab
input actions for switching pages. Change the _input() function to
_unhandled_input().
Move all inside PanelContainer, which have hardcoded positions, 64 pixels
vertically. To adjust to the new row.
Helps #2339