Enhance and refactor COM moniker and binding context tests #902
+181
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves shared constants, functions, and imports related to moniker testing from `test_monikers.py` to a new helper module `monikers_helper.py`.
- Extract `CLSID_AntiMoniker`, `CLSID_ItemMoniker`, `MK_E_UNAVAILABLE` into `monikers_helper.py`. - Refactor test classes in `test_bctx.py`, `test_moniker.py`, and `test_rot.py` for clarity. - Improve test coverage and correctness for moniker-related functions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
==========================================
+ Coverage 85.68% 85.78% +0.10%
==========================================
Files 128 131 +3
Lines 12137 12223 +86
==========================================
+ Hits 10400 10486 +86
Misses 1737 1737 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling Future Test Expansion:
This PR lays the groundwork for expanding the test coverage for
IBindCtx,IMoniker, andIRunningObjectTablemethods.Anticipating that directly adding new tests would lead to overgrown and difficult-to-manage test modules, a proactive restructuring was undertaken.
Structured Test Module Organization:
To prevent test module bloat, the testing landscape for COM interfaces has been segmented. Tests for
IBindCtx,IMoniker, andIRunningObjectTableare now separated into dedicated modules (test_bctx.py,test_moniker.py,test_rot.py).This partitioning ensures that as new method-specific tests are introduced, they can be added to their respective, focused modules, maintaining clarity and manageability.
Eliminating Redundancy with Centralized Helpers:
The modularization of tests necessitated the extraction of common
ctypesfunction definitions and COM-related constants.These shared components were previously duplicated or would have become so across the newly split test files.
By centralizing them into
monikers_helper.py, the project avoids "WET" code.