Skip to content

fix(VaSwitch): Remove horizontal scrollbar behavior#4317

Open
Us3r-gitHub wants to merge 6 commits intoepicmaxco:developfrom
Us3r-gitHub:fix#4315/va-switch
Open

fix(VaSwitch): Remove horizontal scrollbar behavior#4317
Us3r-gitHub wants to merge 6 commits intoepicmaxco:developfrom
Us3r-gitHub:fix#4315/va-switch

Conversation

@Us3r-gitHub
Copy link
Copy Markdown
Contributor

closes #4315

Description

Change translate (CSS transform function) logic
From: Implement on Checker & Checker wrapper
To: Only Implement on Checker

Note: Implementing logic in Checker Wrapper may introduce bug (horizontal scroll behavior)

Markup:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Copy link
Copy Markdown
Collaborator

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Sorry for late response.

I see few issues related to hardcoded rems.

There are cases when we have labels inside, which could take a lot of space.
image

@Us3r-gitHub
Copy link
Copy Markdown
Contributor Author

There are cases when we have labels inside, which could take a lot of space.

I'll try a different method. Any ideas on what I should do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VaSwitch added horizontal scrollbar

3 participants